-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Segfault occuring #201
Comments
Looking at the error message it seems related to the fix implemented in 76917a1 for the high cpu bug, seems to be crashing Clight. |
Hi! That's a great news! Btw I will give a look at this, thank you! |
Thanks for continuing to pursue this issue, hope we can finally solve it soon. Running |
I was able to strace clight up until it crashed recently. Heres is the end of that log: strace
|
Thank you very much! |
Sure, I've rebuilt clight commenting out these two lines https://github.com/FedeDP/Clight/blob/master/src/modules/interface.c#L445-L446. I'll see if I can reproduce it. |
Thank you man! |
Haha yea the most common way of debugging. Here's the strace it seems it still crashed with those lines commented: strace
|
Can you comment
I was thinking the same...it's super weird; while on my laptop still nothing after 3-4d! What are you doing, if i can ask? Ie: watching a movie, playing some games... maybe there is a way to increase this bug frequency! |
Rebuilt with that line commented, running it now. I am not doing anything out of the ordinary. I've got firefox open with a couple of tabs but no media playing. Two terminals open, one with the |
New log, spammed strace
...
|
So, this is the version with all 3 lines commented? |
Yes |
Dope! So we are now sure that this is #106 |
Sure, heres the diff I applied: diff --git a/src/modules/interface.c b/src/modules/interface.c
index fadaf10..1e5e5b7 100644
--- a/src/modules/interface.c
+++ b/src/modules/interface.c
@@ -540,7 +540,7 @@ static int start_inhibit_monitor(void) {
if (r == 0) {
sd_bus_process(monbus, NULL);
int fd = sd_bus_get_fd(monbus);
- m_register_fd(dup(fd), true, monbus);
+ m_register_fd(fd, false, monbus);
}
return r;
} Rebuilding and running now. |
New log! strace
|
That is really really weird... Thank you :) |
Applied patch and rebuilt. High velocity debugging right here |
strace
|
Ran it again and seemed to run into a slightly different log: strace
|
I don't really get what's happening here... ok let's reset to master. |
Applied patch, rebuilt. New log, message ended up looping in strace and no crash (progress!). Two parts: strace
...
|
Nice!
Then it receives some preparing messages for monitoring; I added a sd_bus_message_dump call() there, i want to make clear if we are really receiving a
|
New log after patch: strace
(repeats) |
I find that running clight with strace makes this happen a lot faster than without. Tried letting it run on its own and didn't run into issues immediately like with strace. |
I'll give it a shot then :) |
No problem and alright! Let me know if you want me to test anything else out for you in the future, hope you are able to reproduce it yourself reliably. |
Should I keep these changes you sent or reset back to master in the meantime? |
I'd reset to master (even if it segfaults...)! |
I WAS ABLE TO REPRODUCE IT through strace!! |
With latest master, i am not able to reproduce the crash. Even if i don't really understand why. |
Looks like the crash has indeed been fixed. Just found a |
And... Is screensaver inhibition working after the "Connection reset" message? |
Looks like it is, inhibition is being detected and the correct behavior is occurring |
I really can't believe 😂 Thank you for all your testing!! |
Happy to help! |
NOTE: Please try to upgrade Clight if not running on latest release, before reporting a bug!
Clight version the issue has been seen with:
Used distribution:
Describe the bug
It seems Clight is segfaulting at times, I haven't attempted to reproduce but will once I upload these logs
Expected behavior
Not to segfault
To Reproduce
TBD
clight.log
The text was updated successfully, but these errors were encountered: