Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix 'unknown type int8_t' errors when compiling for aarch64-musl #142

Merged
merged 1 commit into from Jun 2, 2021
Merged

fix 'unknown type int8_t' errors when compiling for aarch64-musl #142

merged 1 commit into from Jun 2, 2021

Conversation

PoroCYon
Copy link
Contributor

@PoroCYon PoroCYon commented Jun 2, 2021

(Context: updating the Void Linux package from 4.4.something to 5.0.22, that's why I keep finding these issues now. Should've checked for new dependencies for the first PR, though...)

This is another error I've found, now when trying to cross-compile: on aarch64-musl, the compilation fails in these two files, being unable to resolve int8_t, probably due to the wrongly placed header includes.

Note: maybe it's a good idea to add the eid-mw Void package to this list

@yoe yoe merged commit 9ba3b90 into Fedict:master Jun 2, 2021
@PoroCYon PoroCYon deleted the fix-int8_t-not-found branch June 2, 2021 12:25
@yoe
Copy link
Member

yoe commented Jun 2, 2021

Adding the void package to that list is something I'll have to ask someone who can actually update the web page (which is not me ;-) )

I've been thinking of just having that list removed and replaced by a link to repology instead, however, which auto-updates and means we wouldn't have to maintain it any more...

@yoe
Copy link
Member

yoe commented Jun 14, 2021

I've been thinking of just having that list removed and replaced by a link to repology instead, however, which auto-updates and means we wouldn't have to maintain it any more...

This has now happened; and as repology contains Void Linux too, Void users will now know that they can just install eid-mw from the repositories.

Side note though: 5.0.22 contains a small, but critical, bug in the validation code of the eid-viewer, which means that under certain circumstances, cards with corrupt data may be considered valid eID cards. The bug was fixed in 5.0.23. Please update to that :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants