Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better dark mode #399

Closed
K4sum1 opened this issue Mar 16, 2024 · 2 comments
Closed

Better dark mode #399

K4sum1 opened this issue Mar 16, 2024 · 2 comments

Comments

@K4sum1
Copy link

K4sum1 commented Mar 16, 2024

Enabling dark mode should also enable the code that displays a dark mode version of the page. An example of this is it should recognize the CSS @media (prefers-color-scheme: dark) if the dark theme is enabled and use it. There are also some websites that do this in JS instead, but I have no idea what all that entails. This CSS code was added to Firefox 67, so it is there. Just this early on it reflected the system settings and not the browser theme. Considering 10 1709 and 8.1 and earlier don't have a proper dark mode, this always defaults to light mode.

Also making the settings page dark like in current Firefox would be cool too.
ScreenShot_20240316035512

@K4sum1
Copy link
Author

K4sum1 commented Mar 17, 2024

So this should be able to be fixed by a GUI option to set browser.in-content.dark-mode to true, and ui.systemUsesDarkTheme to 1. Although I needed to restart browser for it to take effect.

MyPal even already has dark mode settings with these both set.
ScreenShot_20240317062415

@Feodor2
Copy link
Owner

Feodor2 commented Mar 17, 2024

I shall look to set them default

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants