Skip to content

Commit

Permalink
xvba: oopsie :)
Browse files Browse the repository at this point in the history
  • Loading branch information
@FernetMenta
FernetMenta committed Sep 16, 2012
1 parent f0bf2b7 commit a7d4041
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions xbmc/cores/dvdplayer/DVDCodecs/Video/XVBA.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -768,6 +768,7 @@ void CDecoder::DestroySession()
XVBA_Destroy_Decode_Buffers_Input bufInput;
bufInput.size = sizeof(bufInput);
bufInput.num_of_buffers_in_list = 1;
bufInput.session = m_xvbaConfig.xvbaSession;

This comment has been minimized.

Sign in to view

Copy link
@fritsch

fritsch Sep 16, 2012

lol :-) that one is really funny. you (we, as i am to correctly review the code) tried to kill the "old buffers" from the ancient session ... i was digging into this since approx 3 hours now :-)

This comment has been minimized.

Sign in to view

Copy link
@FernetMenta

FernetMenta Sep 16, 2012

Author Owner

it's even worse, session was never initialized in bufInput. No idea how this has ever worked :)

This comment has been minimized.

Sign in to view

Copy link
@fritsch

fritsch Sep 16, 2012

That can't happen.
That doesn't happen on my machine.
That shouldn't happen.
Why does that happen?
Oh, I see.
How did that ever work?

for (unsigned int i=0; i<m_xvbaBufferPool.data_control_buffers.size() ; ++i)
{
Expand Down

0 comments on commit a7d4041

Please sign in to comment.