Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document that NUL (\0) in strings is not supported #169

Closed
2 tasks done
AlekSi opened this issue Dec 14, 2021 · 0 comments · Fixed by #865 or FerretDB/dance#163
Closed
2 tasks done

Document that NUL (\0) in strings is not supported #169

AlekSi opened this issue Dec 14, 2021 · 0 comments · Fixed by #865 or FerretDB/dance#163
Assignees
@w84thesun
Labels
documentation Something user-visible is badly or not documented
Milestone
v0.5.0

Comments

@AlekSi
Copy link
Member

AlekSi commented Dec 14, 2021 •
edited
Loading

PostgreSQL does not support zero bytes (\0, NUL) in strings, including in jsonb strings. We should not try to fix that fact. Instead, let's:

Changes in FerretDB code are not in scope.
@AlekSi AlekSi added the code/bug Some user-visible feature works incorrectly label Dec 14, 2021
@AlekSi AlekSi added this to the Alpha milestone Dec 14, 2021
@AlekSi AlekSi removed this from the Alpha milestone Jan 5, 2022
@AlekSi AlekSi added the not ready Issues that are not ready to be worked on; PRs that should skip CI label Jun 17, 2022
@AlekSi AlekSi changed the title Support NUL (\0) in strings Document that NUL (\0) in strings is not supported Jun 20, 2022
@AlekSi AlekSi added documentation Something user-visible is badly or not documented not ready Issues that are not ready to be worked on; PRs that should skip CI and removed code/bug Some user-visible feature works incorrectly not ready Issues that are not ready to be worked on; PRs that should skip CI labels Jun 20, 2022
@AlekSi AlekSi added validation and removed not ready Issues that are not ready to be worked on; PRs that should skip CI labels Jun 30, 2022
@AlekSi AlekSi assigned noisersup and w84thesun and unassigned noisersup Jul 4, 2022
@w84thesun w84thesun mentioned this issue Jul 8, 2022
Merged
6 tasks
@w84thesun w84thesun added this to the v0.5.0 milestone Jul 8, 2022
@w84thesun w84thesun linked a pull request Jul 8, 2022 that will close this issue
Document that NUL (\0) strings is not supported #865
Merged
6 tasks
AlekSi pushed a commit that referenced this issue Jul 8, 2022
Document that NUL (\0) strings is not supported (#865)
22dcc23 
Refs #169.
@AlekSi AlekSi reopened this Jul 8, 2022
@AlekSi AlekSi mentioned this issue Jul 8, 2022
Merged
@AlekSi AlekSi closed this as completed Jul 8, 2022
AlekSi pushed a commit to FerretDB/dance that referenced this issue Jul 8, 2022
Add diff tests for NUL \0 strings (#163)
f3a8554 
Closes FerretDB/FerretDB#169.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@w84thesun w84thesun

Labels
documentation Something user-visible is badly or not documented
Projects
None yet
Milestone
v0.5.0
3 participants
@AlekSi @w84thesun @noisersup