Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document that NUL (\0) strings is not supported #865

Merged
merged 4 commits into from
Jul 8, 2022

Conversation

w84thesun
Copy link
Contributor

@w84thesun w84thesun commented Jul 8, 2022

Description

This PR refs #169.

Readiness checklist

  • I added tests for new functionality or bugfixes.
  • I ran task all, and it passed.
  • I added/updated comments for both exported and unexported top-level declarations (functions, types, etc).
  • I checked comments rendering with task godocs.
  • (for maintainers only) I set Reviewers, Assignee, Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@w84thesun w84thesun added documentation Something user-visible is badly or not documented code/chore Code maintenance improvements labels Jul 8, 2022
@w84thesun w84thesun added this to the v0.5.0 milestone Jul 8, 2022
@w84thesun w84thesun self-assigned this Jul 8, 2022
@w84thesun w84thesun added the no ci label Jul 8, 2022
@codecov
Copy link

codecov bot commented Jul 8, 2022

Codecov Report

Merging #865 (6e5eff0) into main (6743b59) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #865   +/-   ##
=======================================
  Coverage   59.07%   59.07%           
=======================================
  Files         218      218           
  Lines        9855     9855           
=======================================
  Hits         5822     5822           
  Misses       3322     3322           
  Partials      711      711           
Impacted Files Coverage Δ
internal/util/version/version.go 55.00% <0.00%> (-5.00%) ⬇️
internal/handlers/pg/pgdb/pool.go 57.88% <0.00%> (+0.57%) ⬆️
Flag Coverage Δ
integration 61.51% <ø> (-0.04%) ⬇️
mongodb 18.76% <ø> (-0.04%) ⬇️
pg 61.44% <ø> (-0.04%) ⬇️
unit 24.68% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@w84thesun w84thesun removed the no ci label Jul 8, 2022
@w84thesun w84thesun marked this pull request as ready for review July 8, 2022 11:34
@w84thesun w84thesun requested a review from AlekSi as a code owner July 8, 2022 11:34
@w84thesun w84thesun requested review from a team, seeforschauer and noisersup and removed request for a team July 8, 2022 11:34
@w84thesun w84thesun linked an issue Jul 8, 2022 that may be closed by this pull request
2 tasks
Copy link
Member

@AlekSi AlekSi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@AlekSi AlekSi enabled auto-merge (squash) July 8, 2022 12:15
@AlekSi AlekSi merged commit 22dcc23 into FerretDB:main Jul 8, 2022
@w84thesun w84thesun deleted the issue-169-document-null-strings branch August 4, 2022 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements documentation Something user-visible is badly or not documented
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document that NUL (\0) in strings is not supported
3 participants