Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow empty strings pushdown for Tigris #1940

Closed
2 tasks done
Tracked by #4
noisersup opened this issue Feb 8, 2023 · 1 comment · Fixed by #2110
Closed
2 tasks done
Tracked by #4

Allow empty strings pushdown for Tigris #1940

noisersup opened this issue Feb 8, 2023 · 1 comment · Fixed by #2110
Assignees
@noisersup
Labels
code/enhancement Some user-visible feature could work better
Milestone
v0.9.3

Comments

@noisersup
Copy link
Member

noisersup commented Feb 8, 2023 •
edited

What should be done?

After the proper fix (see references to this issue in code), we should be able to remove the additional check for empty strings in Tigris BuildFilter method.

  • Update skipped test
  • Remove empty field check
@noisersup noisersup added the code/feature Some user-visible feature is not implemented yet label Feb 8, 2023
@AlekSi AlekSi added code/enhancement Some user-visible feature could work better and removed code/feature Some user-visible feature is not implemented yet labels Feb 9, 2023
@AlekSi AlekSi mentioned this issue Feb 9, 2023
Closed
@AlekSi
Copy link
Member

AlekSi commented Feb 27, 2023

After the proper fix (see references to this issue in code)

It seems to be fixed already: https://github.com/FerretDB/tigris-experiments/pull/12#issuecomment-1445916481

@noisersup noisersup mentioned this issue Mar 2, 2023
Merged
9 tasks
@AlekSi AlekSi added this to the v1.0.0 GA milestone Mar 2, 2023
noisersup added a commit that referenced this issue Mar 3, 2023
@noisersup
Allow empty strings pushdown for Tigris (#2110)
852ebf4 
Closes #1940.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@noisersup noisersup

Labels
code/enhancement Some user-visible feature could work better
Projects
None yet
Milestone
v0.9.3
Development

Successfully merging a pull request may close this issue.

Allow empty strings pushdown for Tigris noisersup/FerretDB
3 participants
@AlekSi @noisersup @ferretdb-bot