Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow empty strings pushdown for Tigris #2110

Merged
merged 3 commits into from Mar 3, 2023

Conversation

noisersup
Copy link
Member

@noisersup noisersup commented Mar 2, 2023

Description

Closes #1940.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Assignee, Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@noisersup noisersup self-assigned this Mar 2, 2023
@noisersup noisersup added the code/enhancement Some user-visible feature could work better label Mar 2, 2023
@codecov
Copy link

codecov bot commented Mar 2, 2023

Codecov Report

Merging #2110 (d1809bb) into main (b86480f) will increase coverage by 0.05%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2110      +/-   ##
==========================================
+ Coverage   68.53%   68.59%   +0.05%     
==========================================
  Files         362      362              
  Lines       16373    16370       -3     
==========================================
+ Hits        11222    11229       +7     
+ Misses       4138     4128      -10     
  Partials     1013     1013              
Impacted Files Coverage Δ
internal/handlers/tigris/tigrisdb/query.go 67.60% <ø> (+1.38%) ⬆️
internal/handlers/common/filter.go 84.40% <0.00%> (ø)
internal/handlers/pg/pgdb/database_metadata.go 78.88% <0.00%> (+2.22%) ⬆️
internal/handlers/pg/pgdb/databases.go 72.34% <0.00%> (+6.38%) ⬆️
Flag Coverage Δ
integration 64.72% <ø> (+<0.01%) ⬆️
mongodb 5.51% <ø> (+<0.01%) ⬆️
pg 53.06% <ø> (+<0.01%) ⬆️
tigris 45.18% <ø> (+<0.01%) ⬆️
unit 27.62% <ø> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@noisersup noisersup marked this pull request as ready for review March 2, 2023 16:20
@noisersup noisersup requested a review from a team as a code owner March 2, 2023 16:20
@noisersup noisersup enabled auto-merge (squash) March 2, 2023 16:20
@noisersup
Copy link
Member Author

❯ task test-integration-tigris
task: [test-integration-tigris] go test -count=1 -timeout=11m -race=true -tags=ferretdb_debug,ferretdb_tigris,ferretdb_hana -shuffle=on -coverpkg=../... -coverprofile=integration-tigris.txt . -target-backend=ferretdb-tigris -target-unix-socket=true -tigris-urls=127.0.0.1:8081,127.0.0.1:8091,127.0.0.1:8092,127.0.0.1:8093,127.0.0.1:8094 -compat-url=mongodb://127.0.0.1:47017/

ok      github.com/FerretDB/FerretDB/integration        248.893s        coverage: 51.7% of statements in ../...

AlekSi
AlekSi previously approved these changes Mar 2, 2023
Copy link
Member

@AlekSi AlekSi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AlekSi AlekSi added this to the v1.0.0 GA milestone Mar 2, 2023
Copy link
Member

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@w84thesun w84thesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@noisersup noisersup merged commit 852ebf4 into FerretDB:main Mar 3, 2023
@noisersup noisersup deleted the allow-empty-strings-1940 branch March 3, 2023 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/enhancement Some user-visible feature could work better
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow empty strings pushdown for Tigris
5 participants