New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow empty strings pushdown for Tigris #2110
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2110 +/- ##
==========================================
+ Coverage 68.53% 68.59% +0.05%
==========================================
Files 362 362
Lines 16373 16370 -3
==========================================
+ Hits 11222 11229 +7
+ Misses 4138 4128 -10
Partials 1013 1013
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also update https://github.com/FerretDB/FerretDB/blob/main/build/deps/tigris.Dockerfile to use beta.45 https://hub.docker.com/r/tigrisdata/tigris-local/tags just to be sure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Description
Closes #1940.
Readiness checklist
task all
, and it passed.@FerretDB/core
), Assignee, Labels, Project and project's Sprint fields.