You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
🎯 Currently, schema comparison method func (s *Schema) Equal(other *Schema) bool is implemented with reflect.DeepEqual. The goal of this task is to come up with a better approach.
This task is a part of #683 epic.
🎯 Currently, schema comparison method
func (s *Schema) Equal(other *Schema) bool
is implemented withreflect.DeepEqual
. The goal of this task is to come up with a better approach.The target code is located here.
Tigris' data types consist of type and format. For
int64
anddouble
format is not required but might be set.Having that in mind, the following schemas must be equal:
As well as:
We need to fix comparison to make such schemas equal.
Checklist:
int64
anddouble
are the only cases that can cause different schemas need to be equal.The text was updated successfully, but these errors were encountered: