-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tjson
: Fix schema comparison
#944
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #944 +/- ##
==========================================
+ Coverage 61.94% 62.05% +0.11%
==========================================
Files 228 228
Lines 10610 10657 +47
==========================================
+ Hits 6572 6613 +41
- Misses 3259 3262 +3
- Partials 779 782 +3
Flags with carried forward coverage won't be shown. Click here to find out more. |
rumyantseva
commented
Jul 26, 2022
rumyantseva
requested review from
AlekSi,
a team,
w84thesun and
noisersup
and removed request for
a team
July 26, 2022 14:02
AlekSi
requested changes
Jul 26, 2022
w84thesun
reviewed
Jul 27, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, got a small question about test.
w84thesun
previously approved these changes
Jul 27, 2022
AlekSi
reviewed
Jul 27, 2022
Co-authored-by: Alexey Palazhchenko <alexey.palazhchenko@gmail.com>
…rretDB into issue-907-fix-schema-comp
AlekSi
previously approved these changes
Jul 27, 2022
w84thesun
previously approved these changes
Jul 27, 2022
noisersup
previously approved these changes
Jul 27, 2022
rumyantseva
dismissed stale reviews from noisersup, w84thesun, and AlekSi
via
July 27, 2022 13:00
7c6c160
w84thesun
approved these changes
Jul 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR closes #907.
This implementation offers recursive calls of
schema.Equal
instead ofreflect.DeepEqual
.Schemas are considered equal if:
Readiness checklist
task all
, and it passed.task godocs
.