Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for arrays in tjson #908

Closed
5 tasks done
Tracked by #229
rumyantseva opened this issue Jul 18, 2022 · 2 comments · Fixed by #1721
Closed
5 tasks done
Tracked by #229

Add support for arrays in tjson #908

rumyantseva opened this issue Jul 18, 2022 · 2 comments · Fixed by #1721
Assignees
Labels
code/chore Code maintenance improvements
Milestone

Comments

@rumyantseva
Copy link
Member

rumyantseva commented Jul 18, 2022

In Tigris, arrays are defined according to the schema. All values of the array have the same type defined in the schema.

In this task we add support of arrays to tjson and write unit tests to check that they work correctly. The full enablement of Tigris arrays will be handled in #1704.

Definition of done

  • No TODOs mentioning this issue are left in the code
  • Add unit tests (use pjson as a reference):
    • unit tests for arrays in tjson/array_test.go;
    • array examples in tjson/document_test.go.
@rumyantseva rumyantseva added code/feature Some user-visible feature is not implemented yet not ready Issues that are not ready to be worked on; PRs that should skip CI labels Jul 18, 2022
@rumyantseva rumyantseva mentioned this issue Jul 18, 2022
10 tasks
@rumyantseva rumyantseva changed the title [wip] tjson: Add support for arrays tjson: Add support for arrays Jul 20, 2022
@rumyantseva
Copy link
Member Author

This task needs a better description and a decision about how to deal with arrays.

@rumyantseva rumyantseva removed the not ready Issues that are not ready to be worked on; PRs that should skip CI label Dec 23, 2022
@rumyantseva rumyantseva added the not ready Issues that are not ready to be worked on; PRs that should skip CI label Dec 27, 2022
@rumyantseva
Copy link
Member Author

TODO: split the task (unit / integration), so we can estimate it better

@rumyantseva rumyantseva added code/chore Code maintenance improvements and removed code/feature Some user-visible feature is not implemented yet labels Dec 27, 2022
@rumyantseva rumyantseva changed the title tjson: Add support for arrays Add support for arrays in tjson Dec 27, 2022
@rumyantseva rumyantseva removed the not ready Issues that are not ready to be worked on; PRs that should skip CI label Dec 27, 2022
rumyantseva added a commit that referenced this issue Jan 3, 2023
@AlekSi AlekSi added this to the v0.8.1 milestone Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants