-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support arrays in tjson
#1721
Support arrays in tjson
#1721
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1721 +/- ##
==========================================
+ Coverage 69.00% 69.20% +0.20%
==========================================
Files 301 302 +1
Lines 14303 14394 +91
==========================================
+ Hits 9870 9962 +92
+ Misses 3502 3492 -10
- Partials 931 940 +9
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The arrays logic seems good, also test cases look reasonable! A few notes/questions here. Please have in mind that we can skip these notes if we want to deliver it asap and maybe discuss them later
Co-authored-by: Patryk Kwiatek <patryk@kwiatek.xyz>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
Closes #908.
Note: "happy path" for arrays work:
Complicated cases, invalid arrays, and skipped tests will be covered in #1704.
Readiness checklist
task all
, and it passed.task godocs
.@FerretDB/core
), Assignee, Labels, Project and project's Sprint fields.