Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collect sizes in MsgListDatabases for Tigris #1043

Merged
merged 22 commits into from
Aug 22, 2022
Merged

Collect sizes in MsgListDatabases for Tigris #1043

merged 22 commits into from
Aug 22, 2022

Conversation

w84thesun
Copy link
Contributor

@w84thesun w84thesun commented Aug 16, 2022 •
edited by AlekSi

Description

This PR closes #776.

Readiness checklist

  • I added tests for new functionality or bugfixes.
  • I ran task all, and it passed.
  • I added/updated comments for both exported and unexported top-level declarations (functions, types, etc).
  • I checked comments rendering with task godocs.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Assignee, Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@w84thesun w84thesun added the code/enhancement Some user-visible feature could work better label Aug 16, 2022
@w84thesun w84thesun added this to the v0.6.0 milestone Aug 16, 2022
@w84thesun w84thesun self-assigned this Aug 16, 2022
@w84thesun w84thesun changed the title Add sizes collection to MsgListDatabases response for Tigris Add collections sizes to MsgListDatabases response for Tigris Aug 16, 2022
@codecov
Copy link

codecov bot commented Aug 16, 2022 •
edited

Codecov Report

Merging #1043 (8e2a300) into main (935a7c8) will increase coverage by 0.39%.
The diff coverage is 58.62%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1043      +/-   ##
==========================================
+ Coverage   64.16%   64.55%   +0.39%     
==========================================
  Files         243      243              
  Lines       11514    11523       +9     
==========================================
+ Hits         7388     7439      +51     
+ Misses       3272     3217      -55     
- Partials      854      867      +13
Impacted Files Coverage Δ
integration/setup/setup.go 86.45% <50.00%> (-5.21%) ⬇️
internal/handlers/tigris/msg_listdatabases.go 45.07% <57.14%> (+45.07%) ⬆️
internal/handlers/tigris/tigrisdb/errors.go 66.66% <66.66%> (+12.12%) ⬆️
integration/setup/setup_compat.go 87.61% <100.00%> (ø)
internal/util/version/version.go 55.00% <0.00%> (-5.00%) ⬇️
internal/handlers/common/filter.go 85.38% <0.00%> (ø)
internal/handlers/pg/pgdb/databases.go 58.82% <0.00%> (+4.70%) ⬆️
internal/handlers/pg/msg_listdatabases.go 60.43% <0.00%> (+13.18%) ⬆️
Flag Coverage Δ
integration 60.39% <58.62%> (+0.36%) ⬆️
mongodb 18.53% <46.15%> (+0.02%) ⬆️
pg 62.58% <53.84%> (+0.07%) ⬆️
tigris 29.31% <58.62%> (+0.32%) ⬆️
unit 25.35% <18.75%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

rumyantseva
rumyantseva requested changes Aug 16, 2022
View reviewed changes
Copy link
Member

@rumyantseva rumyantseva left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, this was not for this PR :0

@rumyantseva rumyantseva self-requested a review August 16, 2022 13:36
@w84thesun w84thesun requested review from a team, AlekSi and noisersup and removed request for a team August 18, 2022 10:44
@w84thesun w84thesun marked this pull request as ready for review August 18, 2022 10:44
@w84thesun w84thesun requested a review from a team as a code owner August 18, 2022 10:44
noisersup
noisersup previously approved these changes Aug 18, 2022
View reviewed changes
Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

noisersup
noisersup previously approved these changes Aug 18, 2022
View reviewed changes
rumyantseva
rumyantseva previously approved these changes Aug 18, 2022
View reviewed changes
Copy link
Member

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlekSi
Copy link
Member

AlekSi commented Aug 18, 2022

Add collections sizes to MsgListDatabases response for Tigris

That method should return database sizes, not collection sizes

@AlekSi AlekSi assigned AlekSi and unassigned w84thesun Aug 22, 2022
@AlekSi AlekSi dismissed stale reviews from rumyantseva and noisersup via 8e2a300 August 22, 2022 13:36
@AlekSi AlekSi changed the title Add collections sizes to MsgListDatabases response for Tigris Collect sizes in MsgListDatabases for Tigris Aug 22, 2022
@AlekSi AlekSi requested review from AlekSi, noisersup, rumyantseva and a team August 22, 2022 13:40
@AlekSi AlekSi enabled auto-merge (squash) August 22, 2022 13:41
rumyantseva
rumyantseva approved these changes Aug 22, 2022
View reviewed changes
Copy link
Member

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlekSi AlekSi merged commit cb59786 into FerretDB:main Aug 22, 2022
@w84thesun w84thesun deleted the issue-776-collect-sizes-in-msglistdatabases-tigris branch September 7, 2022 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlekSi AlekSi AlekSi approved these changes

@rumyantseva rumyantseva rumyantseva approved these changes

@noisersup noisersup Awaiting requested review from noisersup

Assignees

@AlekSi AlekSi

Labels
code/enhancement Some user-visible feature could work better
Projects
None yet
Milestone
v0.5.3
Development

Successfully merging this pull request may close these issues.

Collect sizes in MsgListDatabases for Tigris
4 participants
@w84thesun @AlekSi @rumyantseva @noisersup