-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for update with replacement #1044
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WLS linter and some tests fail, this is why I reject.
I don't see critical things, so when it's fixed, I will be ready to approve.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please resolve conflicts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests still fail, right? Do you need any help with it?
# Conflicts: # internal/handlers/tigris/msg_update.go # internal/handlers/tigris/tigris.go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, one tiny question.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are still failing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw those PG currentDate
tests failed several times. Should we create an issue for that?
Codecov Report
@@ Coverage Diff @@
## main #1044 +/- ##
==========================================
+ Coverage 63.78% 63.96% +0.17%
==========================================
Files 240 240
Lines 11344 11369 +25
==========================================
+ Hits 7236 7272 +36
+ Misses 3262 3251 -11
Partials 846 846
Flags with carried forward coverage won't be shown. Click here to find out more. |
I will try to fix the underlying issue tomorrow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the tests pass, I'm happy with the changes.
@noisersup PTAL |
Readiness checklist
task all
, and it passed.task godocs
.@FerretDB/core
), Assignee, Labels, Project and project's Sprint fields.