Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for update with replacement #1044

Merged
merged 15 commits into from
Aug 18, 2022
Merged

Add tests for update with replacement #1044

merged 15 commits into from
Aug 18, 2022

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Aug 16, 2022

Readiness checklist

  • I added tests for new functionality or bugfixes.
  • I ran task all, and it passed.
  • I added/updated comments for both exported and unexported top-level declarations (functions, types, etc).
  • I checked comments rendering with task godocs.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Assignee, Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added the code/chore Code maintenance improvements label Aug 16, 2022
@AlekSi AlekSi added this to the v0.6.0 milestone Aug 16, 2022
@AlekSi AlekSi self-assigned this Aug 16, 2022
@AlekSi AlekSi requested a review from a team as a code owner August 16, 2022 12:08
@AlekSi AlekSi requested review from rumyantseva, a team, w84thesun and noisersup and removed request for a team August 16, 2022 12:08
rumyantseva
rumyantseva requested changes Aug 16, 2022
View reviewed changes
Copy link
Member

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WLS linter and some tests fail, this is why I reject.

I don't see critical things, so when it's fixed, I will be ready to approve.

integration/setup/common.go Show resolved Hide resolved
integration/update_field_compat_test.go Outdated Show resolved Hide resolved
internal/handlers/tigris/msg_update.go Outdated Show resolved Hide resolved
w84thesun
w84thesun reviewed Aug 16, 2022
View reviewed changes
Copy link
Contributor

@w84thesun w84thesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve conflicts.

@AlekSi
WIP
9072d1e
@AlekSi
WIP
5a0859a
@AlekSi
Merge branch 'main' into update-replace
186cafc 
# Conflicts:
#	internal/handlers/tigris/msg_update.go
@AlekSi
WIP
fe2c975
noisersup
noisersup previously approved these changes Aug 16, 2022
View reviewed changes
Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlekSi AlekSi requested review from w84thesun, noisersup, rumyantseva and a team August 16, 2022 13:26
rumyantseva
rumyantseva reviewed Aug 16, 2022
View reviewed changes
Copy link
Member

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests still fail, right? Do you need any help with it?

@AlekSi
Merge branch 'main' into update-replace
0ad0e5b 
# Conflicts:
#	internal/handlers/tigris/msg_update.go
#	internal/handlers/tigris/tigris.go
@AlekSi AlekSi enabled auto-merge (squash) August 17, 2022 14:32
@AlekSi AlekSi requested review from rumyantseva and a team August 17, 2022 14:32
@AlekSi AlekSi requested a review from a team August 17, 2022 14:32
rumyantseva
rumyantseva previously approved these changes Aug 17, 2022
View reviewed changes
Copy link
Member

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, one tiny question.

internal/handlers/tigris/tigrisdb/errors.go Outdated Show resolved Hide resolved
noisersup
noisersup requested changes Aug 17, 2022
View reviewed changes
Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are still failing

w84thesun
w84thesun suggested changes Aug 17, 2022
View reviewed changes
Copy link
Contributor

@w84thesun w84thesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw those PG currentDate tests failed several times. Should we create an issue for that?

@codecov
Copy link

codecov bot commented Aug 17, 2022 •
edited

Codecov Report

Merging #1044 (812bd31) into main (ce8aa60) will increase coverage by 0.17%.
The diff coverage is 84.78%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1044      +/-   ##
==========================================
+ Coverage   63.78%   63.96%   +0.17%     
==========================================
  Files         240      240              
  Lines       11344    11369      +25     
==========================================
+ Hits         7236     7272      +36     
+ Misses       3262     3251      -11     
  Partials      846      846
Impacted Files Coverage Δ
internal/handlers/common/error.go 82.65% <ø> (ø)
internal/handlers/common/errorcode_string.go 80.00% <ø> (ø)
internal/handlers/tigris/msg_update.go 41.72% <77.77%> (+4.48%) ⬆️
internal/handlers/tigris/tigrisdb/errors.go 54.54% <80.00%> (+29.54%) ⬆️
internal/util/testutil/db.go 87.30% <83.33%> (+0.63%) ⬆️
integration/setup/common.go 92.85% <100.00%> (+0.33%) ⬆️
integration/shareddata/shareddata.go 82.81% <100.00%> (+0.27%) ⬆️
internal/util/version/version.go 55.00% <0.00%> (-5.00%) ⬇️
internal/handlers/common/filter.go 85.38% <0.00%> (ø)
... and 3 more
Flag Coverage Δ
integration 59.86% <84.78%> (+0.15%) ⬆️
mongodb 18.38% <71.87%> (+0.12%) ⬆️
pg 62.49% <71.87%> (+0.04%) ⬆️
tigris 28.09% <84.78%> (+0.48%) ⬆️
unit 24.89% <55.26%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi
Copy link
Member Author

AlekSi commented Aug 17, 2022

I saw those PG currentDate tests failed several times. Should we create an issue for that?

I will try to fix the underlying issue tomorrow

@AlekSi AlekSi requested review from noisersup, w84thesun, rumyantseva and a team August 17, 2022 18:24
rumyantseva
rumyantseva approved these changes Aug 17, 2022
View reviewed changes
Copy link
Member

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the tests pass, I'm happy with the changes.

@AlekSi
Copy link
Member Author

AlekSi commented Aug 18, 2022

@noisersup PTAL

@AlekSi AlekSi merged commit 4ff5c27 into FerretDB:main Aug 18, 2022
@AlekSi AlekSi deleted the update-replace branch August 18, 2022 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@w84thesun w84thesun w84thesun approved these changes

@rumyantseva rumyantseva rumyantseva approved these changes

@noisersup noisersup noisersup approved these changes

Assignees

@AlekSi AlekSi

Labels
code/chore Code maintenance improvements
Projects
None yet
Milestone
v0.5.3
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@AlekSi @w84thesun @rumyantseva @noisersup