-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement MsgDBStats
for Tigris
#1047
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1047 +/- ##
===========================================
+ Coverage 40.12% 63.87% +23.74%
===========================================
Files 240 240
Lines 11281 11344 +63
===========================================
+ Hits 4527 7246 +2719
+ Misses 6121 3252 -2869
- Partials 633 846 +213
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any implementation of freeStorage field. Is it in the scope of this task?
@noisersup I don't think we have it implemented for Postgres, and I believe now we need to focus on the main functionality, so freeStorage is for future, not for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
This PR closes #774
Readiness checklist
task all
, and it passed.task godocs
.@FerretDB/core
), Assignee, Labels, Project and project's Sprint fields.