Migrate to MongoDB 6 #1074
Merged
Migrate to MongoDB 6 #1074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 24, 2022
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1074 +/- ##
==========================================
+ Coverage 65.90% 66.16% +0.26%
==========================================
Files 248 248
Lines 11874 11950 +76
==========================================
+ Hits 7825 7907 +82
+ Misses 3185 3176 -9
- Partials 864 867 +3
Flags with carried forward coverage won't be shown. Click here to find out more. |
Closed
w84thesun
requested review from
a team,
w84thesun,
rumyantseva and
noisersup
and removed request for
a team
Closed
noisersup
approved these changes
Sep 2, 2022
|
@rumyantseva PTAL |
rumyantseva
approved these changes
Sep 2, 2022
AlekSi
commented
Sep 2, 2022
Comment on lines
+72
to
74
| Message: `No log named 'nonExistentName'`, | ||
| }, | ||
| alt: `no RecentEntries named: nonExistentName`, |
There was a problem hiding this comment.
Do we need both messages there? I think they should be the same now
| @@ -50,11 +50,11 @@ func TestCommandsReplicationIsMaster(t *testing.T) { | |||
| delete(m, "localTime") | |||
|
|
|||
| maxWireVersion := m["maxWireVersion"].(int32) | |||
| assert.True(t, maxWireVersion == 0 || maxWireVersion == 13) | |||
| assert.True(t, maxWireVersion == 0 || maxWireVersion == 17) | |||
There was a problem hiding this comment.
Let's add a comment explaining why we need == 0 in those lines
Comment on lines
+489
to
+491
| Message: ` invalid flag in regex options: 1`, | ||
| }, | ||
| altMessage: `invalid flag in regex options: 1`, |
There was a problem hiding this comment.
I think altMessage was supposed to be MongoDB's error, not vise versa.
Let's rename AssertEqualAltError argument names and update docs to mention that if that's true
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #1083.
Readiness checklist
task all, and it passed.task godocs.@FerretDB/core), Assignee, Labels, Project and project's Sprint fields.