Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fixed -test-record directory in Task targets #1139

Merged
merged 1 commit into from
Sep 12, 2022

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Sep 12, 2022

Description

For the future fuzzing tasks.

Readiness checklist

  • I added tests for new functionality or bugfixes.
  • I ran task all, and it passed.
  • I added/updated comments for both exported and unexported top-level declarations (functions, types, etc).
  • I checked comments rendering with task godocs.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Assignee, Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added code/chore Code maintenance improvements area/fuzz Issues about fuzzing and smithing labels Sep 12, 2022
@AlekSi AlekSi added this to the v0.5.4 milestone Sep 12, 2022
@AlekSi AlekSi self-assigned this Sep 12, 2022
@vercel
Copy link

vercel bot commented Sep 12, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ferret-db ✅ Ready (Inspect) Visit Preview Sep 12, 2022 at 3:39PM (UTC)

@AlekSi AlekSi requested review from a team, w84thesun, rumyantseva and noisersup and removed request for a team September 12, 2022 15:38
@AlekSi AlekSi marked this pull request as ready for review September 12, 2022 15:39
@AlekSi AlekSi enabled auto-merge (squash) September 12, 2022 15:39
@vercel vercel bot temporarily deployed to Preview September 12, 2022 15:39 Inactive
Copy link
Member

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Sep 12, 2022

Codecov Report

Merging #1139 (9f716bd) into main (780099f) will decrease coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1139      +/-   ##
==========================================
- Coverage   66.20%   66.18%   -0.03%     
==========================================
  Files         250      250              
  Lines       12228    12228              
==========================================
- Hits         8096     8093       -3     
- Misses       3243     3245       +2     
- Partials      889      890       +1     
Impacted Files Coverage Δ
internal/util/version/version.go 55.00% <0.00%> (-5.00%) ⬇️
internal/handlers/common/filter.go 86.01% <0.00%> (ø)
Flag Coverage Δ
integration 62.31% <ø> (-0.03%) ⬇️
mongodb 14.80% <ø> (-0.03%) ⬇️
pg 51.80% <ø> (-0.03%) ⬇️
tigris 34.11% <ø> (-0.03%) ⬇️
unit 24.07% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi merged commit f7329f4 into FerretDB:main Sep 12, 2022
@AlekSi AlekSi deleted the record-dir branch September 12, 2022 15:43
rumyantseva pushed a commit to rumyantseva/FerretDB that referenced this pull request Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/fuzz Issues about fuzzing and smithing code/chore Code maintenance improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants