Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate fuzztool to Kong #1159

Merged
merged 20 commits into from
Sep 20, 2022
Merged

Migrate fuzztool to Kong #1159

merged 20 commits into from
Sep 20, 2022

Conversation

noisersup
Copy link
Member

@noisersup noisersup commented Sep 16, 2022

Description

This PR closes #1103.

Readiness checklist

  • I added tests for new functionality or bugfixes.
  • I ran task all, and it passed.
  • I added/updated comments for both exported and unexported top-level declarations (functions, types, etc).
  • I checked comments rendering with task godocs.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Assignee, Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@noisersup noisersup added code/chore Code maintenance improvements area/fuzz Issues about fuzzing and smithing labels Sep 16, 2022
@noisersup noisersup added this to the v0.5.4 milestone Sep 16, 2022
@noisersup noisersup self-assigned this Sep 16, 2022
@vercel
Copy link

vercel bot commented Sep 16, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ferret-db ✅ Ready (Inspect) Visit Preview Sep 20, 2022 at 11:19AM (UTC)

@vercel vercel bot temporarily deployed to Preview September 16, 2022 13:32 Inactive
@codecov
Copy link

codecov bot commented Sep 16, 2022

Codecov Report

Merging #1159 (b3e23a4) into main (4507491) will increase coverage by 0.09%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1159      +/-   ##
==========================================
+ Coverage   66.22%   66.32%   +0.09%     
==========================================
  Files         250      250              
  Lines       12232    12232              
==========================================
+ Hits         8101     8113      +12     
+ Misses       3244     3233      -11     
+ Partials      887      886       -1     
Impacted Files Coverage Δ
internal/util/version/version.go 55.00% <0.00%> (-5.00%) ⬇️
internal/handlers/common/filter.go 86.95% <0.00%> (+0.93%) ⬆️
internal/handlers/pg/pgdb/collections.go 56.92% <0.00%> (+4.61%) ⬆️
Flag Coverage Δ
integration 62.41% <ø> (+0.04%) ⬆️
mongodb 14.81% <ø> (-0.01%) ⬇️
pg 51.84% <ø> (+0.04%) ⬆️
tigris 34.07% <ø> (-0.03%) ⬇️
unit 24.31% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@vercel vercel bot temporarily deployed to Preview September 17, 2022 01:34 Inactive
@vercel vercel bot temporarily deployed to Preview September 17, 2022 01:51 Inactive
@vercel vercel bot temporarily deployed to Preview September 17, 2022 01:55 Inactive
@vercel vercel bot temporarily deployed to Preview September 18, 2022 01:42 Inactive
@vercel vercel bot temporarily deployed to Preview September 19, 2022 01:53 Inactive
@vercel vercel bot temporarily deployed to Preview September 19, 2022 10:55 Inactive
@vercel vercel bot temporarily deployed to Preview September 19, 2022 11:15 Inactive
@vercel vercel bot temporarily deployed to Preview September 19, 2022 11:20 Inactive
@vercel vercel bot temporarily deployed to Preview September 19, 2022 13:15 Inactive
@vercel vercel bot temporarily deployed to Preview September 19, 2022 13:34 Inactive
@vercel vercel bot temporarily deployed to Preview September 19, 2022 13:44 Inactive
@vercel vercel bot temporarily deployed to Preview September 19, 2022 21:06 Inactive
@vercel vercel bot temporarily deployed to Preview September 19, 2022 21:14 Inactive
@vercel vercel bot temporarily deployed to Preview September 19, 2022 21:15 Inactive
@vercel vercel bot temporarily deployed to Preview September 19, 2022 21:21 Inactive
Copy link
Member

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation is missing in one place + asked a couple of questions.

cmd/fuzztool/fuzztool.go Outdated Show resolved Hide resolved
cmd/fuzztool/fuzztool.go Outdated Show resolved Hide resolved
Copy link
Member

@AlekSi AlekSi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(for maintainers only) I set [...] project's Sprint fields.

It is not set

@vercel vercel bot temporarily deployed to Preview September 20, 2022 10:56 Inactive
@vercel vercel bot temporarily deployed to Preview September 20, 2022 11:01 Inactive
@noisersup
Copy link
Member Author

noisersup commented Sep 20, 2022

@AlekSi The last thing is that I couldn't add the fuzz label, which is present in the issue.

Conform PR

@vercel vercel bot temporarily deployed to Preview September 20, 2022 11:06 Inactive
@vercel vercel bot temporarily deployed to Preview September 20, 2022 11:19 Inactive
@AlekSi AlekSi added the area/fuzz Issues about fuzzing and smithing label Sep 20, 2022
Copy link
Member

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlekSi AlekSi removed the area/fuzz Issues about fuzzing and smithing label Sep 20, 2022
@AlekSi
Copy link
Member

AlekSi commented Sep 20, 2022

The last thing is that I couldn't add the fuzz label, which is present in the issue.

fuzz label has the following description: Temporary label for issues about fuzzing

PR is not an issue.

@AlekSi AlekSi merged commit 4116718 into FerretDB:main Sep 20, 2022
@noisersup noisersup deleted the fuzztool-kong-1103 branch September 20, 2022 15:01
fenogentov pushed a commit to fenogentov/FerretDB that referenced this pull request Sep 26, 2022
@AlekSi AlekSi mentioned this pull request Oct 14, 2022
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate fuzztool to Kong
3 participants