Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use single transaction per msg_insert request #1213

Merged

Conversation

rumyantseva
Copy link
Member

@rumyantseva rumyantseva commented Oct 5, 2022

Description

This PR refs #1203.

This PR didn't fix the tests, but I consider it an improvement, so please review.

Readiness checklist

  • I added tests for new functionality or bugfixes.
  • I ran task all, and it passed.
  • I added/updated comments for both exported and unexported top-level declarations (functions, types, etc).
  • I checked comments rendering with task godocs.
  • I ensured that the title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Assignee, Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@vercel
Copy link

vercel bot commented Oct 5, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ferret-db ✅ Ready (Inspect) Visit Preview Oct 5, 2022 at 10:40AM (UTC)

@vercel vercel bot temporarily deployed to Preview October 5, 2022 10:37 Inactive
@vercel vercel bot temporarily deployed to Preview October 5, 2022 10:40 Inactive
@rumyantseva rumyantseva self-assigned this Oct 5, 2022
@rumyantseva rumyantseva linked an issue Oct 5, 2022 that may be closed by this pull request
@rumyantseva rumyantseva requested review from a team, AlekSi, w84thesun and noisersup and removed request for a team October 5, 2022 10:42
@codecov
Copy link

codecov bot commented Oct 5, 2022

Codecov Report

Merging #1213 (d7000e1) into main (c349a2b) will increase coverage by 0.06%.
The diff coverage is 50.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1213      +/-   ##
==========================================
+ Coverage   66.39%   66.45%   +0.06%     
==========================================
  Files         252      252              
  Lines       12324    12331       +7     
==========================================
+ Hits         8182     8195      +13     
+ Misses       3250     3243       -7     
- Partials      892      893       +1     
Impacted Files Coverage Δ
internal/handlers/pg/msg_update.go 57.55% <0.00%> (ø)
internal/handlers/pg/msg_insert.go 41.42% <43.47%> (+2.03%) ⬆️
internal/handlers/pg/msg_findandmodify.go 73.21% <100.00%> (+0.36%) ⬆️
internal/util/version/version.go 55.00% <0.00%> (-5.00%) ⬇️
internal/handlers/common/filter.go 86.58% <0.00%> (ø)
internal/handlers/pg/pgdb/query.go 43.44% <0.00%> (+2.75%) ⬆️
internal/handlers/pg/pgdb/settings.go 44.18% <0.00%> (+4.65%) ⬆️
Flag Coverage Δ
integration 62.70% <50.00%> (+0.03%) ⬆️
mongodb 14.82% <0.00%> (-0.02%) ⬇️
pg 51.84% <50.00%> (+0.04%) ⬆️
tigris 34.86% <0.00%> (-0.05%) ⬇️
unit 24.12% <0.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@AlekSi AlekSi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please mark this PR as ready for review when ready

@rumyantseva rumyantseva marked this pull request as ready for review October 5, 2022 10:44
@rumyantseva rumyantseva requested a review from a team as a code owner October 5, 2022 10:44
@rumyantseva rumyantseva enabled auto-merge (squash) October 5, 2022 10:44
@rumyantseva rumyantseva merged commit fb8c056 into FerretDB:main Oct 5, 2022
@rumyantseva rumyantseva deleted the issue-1203-insert-transactions branch October 5, 2022 10:46
@AlekSi AlekSi added this to the v0.6.0 Alpha milestone Oct 10, 2022
@AlekSi AlekSi added the code/enhancement Some user-visible feature could work better label Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/enhancement Some user-visible feature could work better
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix fluky tests
3 participants