Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add update operators data document fields order test #1238

Merged
merged 8 commits into from
Oct 11, 2022

Conversation

w84thesun
Copy link
Contributor

@w84thesun w84thesun commented Oct 11, 2022

Description

This PR closes #1138.

Readiness checklist

  • I added tests for new functionality or bugfixes.
  • I ran task all, and it passed.
  • I added/updated comments for both exported and unexported top-level declarations (functions, types, etc).
  • I checked comments rendering with task godocs.
  • I ensured that the title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Assignee, Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@vercel
Copy link

vercel bot commented Oct 11, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ferret-db ✅ Ready (Inspect) Visit Preview Oct 11, 2022 at 9:48PM (UTC)

@vercel vercel bot temporarily deployed to Preview October 11, 2022 09:34 Inactive
@vercel vercel bot temporarily deployed to Preview October 11, 2022 09:49 Inactive
@codecov
Copy link

codecov bot commented Oct 11, 2022

Codecov Report

Merging #1238 (211a6fd) into main (470940b) will decrease coverage by 0.11%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1238      +/-   ##
==========================================
- Coverage   66.58%   66.47%   -0.12%     
==========================================
  Files         268      268              
  Lines       12974    12974              
==========================================
- Hits         8639     8624      -15     
- Misses       3390     3403      +13     
- Partials      945      947       +2     
Impacted Files Coverage Δ
internal/handlers/pg/pgdb/settings.go 39.53% <0.00%> (-4.66%) ⬇️
internal/util/version/version.go 48.52% <0.00%> (-4.42%) ⬇️
internal/handlers/common/filter.go 86.58% <0.00%> (-0.63%) ⬇️
Flag Coverage Δ
integration 60.92% <ø> (-0.12%) ⬇️
mongodb 14.04% <ø> (-0.03%) ⬇️
pg 50.73% <ø> (-0.12%) ⬇️
tigris 33.05% <ø> (-0.03%) ⬇️
unit 25.95% <ø> (-0.33%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@vercel vercel bot temporarily deployed to Preview October 11, 2022 09:56 Inactive
@w84thesun w84thesun self-assigned this Oct 11, 2022
@w84thesun w84thesun added the code/enhancement Some user-visible feature could work better label Oct 11, 2022
@w84thesun w84thesun added this to the v0.6.0 Alpha milestone Oct 11, 2022
@w84thesun w84thesun changed the title Add update operators test Add update operators data document fields order test Oct 11, 2022
@w84thesun w84thesun marked this pull request as ready for review October 11, 2022 10:58
@w84thesun w84thesun requested a review from a team as a code owner October 11, 2022 10:58
@w84thesun w84thesun requested review from AlekSi, rumyantseva, a team, chilagrow and noisersup and removed request for a team October 11, 2022 10:58
Copy link
Member

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@w84thesun w84thesun enabled auto-merge (squash) October 11, 2022 21:47
@vercel vercel bot temporarily deployed to Preview October 11, 2022 21:48 Inactive
@w84thesun w84thesun merged commit 8ab516d into FerretDB:main Oct 11, 2022
@w84thesun w84thesun deleted the issue-1138-fields-order-tests branch October 11, 2022 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/enhancement Some user-visible feature could work better
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tests for preserving fields order in data documents
4 participants