Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup types/fjson package #1254

Merged
merged 6 commits into from
Oct 14, 2022
Merged

Cleanup types/fjson package #1254

merged 6 commits into from
Oct 14, 2022

Conversation

chilagrow
Copy link
Contributor

@chilagrow chilagrow commented Oct 13, 2022 •
edited

Description

This PR closes #1236.

Readiness checklist

  • I added tests for new functionality or bugfixes.
  • I ran task all, and it passed.
  • I added/updated comments for both exported and unexported top-level declarations (functions, types, etc).
  • I checked comments rendering with task godocs.
  • I ensured that the title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Assignee, Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@CLAassistant
Copy link

CLAassistant commented Oct 13, 2022 •
edited

CLA assistant check
All committers have signed the CLA.

@vercel
Copy link

vercel bot commented Oct 13, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ferret-db ✅ Ready (Inspect) Visit Preview Oct 13, 2022 at 0:12AM (UTC)

@vercel vercel bot temporarily deployed to Preview October 13, 2022 02:53 Inactive
@vercel vercel bot temporarily deployed to Preview October 13, 2022 06:27 Inactive
@codecov
Copy link

codecov bot commented Oct 13, 2022 •
edited

Codecov Report

Merging #1254 (fdc89f2) into main (bcd44e9) will increase coverage by 0.05%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1254      +/-   ##
==========================================
+ Coverage   66.37%   66.43%   +0.05%     
==========================================
  Files         269      269              
  Lines       12903    12575     -328     
==========================================
- Hits         8565     8354     -211     
+ Misses       3392     3315      -77     
+ Partials      946      906      -40
Impacted Files Coverage Δ
internal/types/fjson/array.go 68.18% <ø> (+7.31%) ⬆️
internal/types/fjson/binary.go 60.00% <ø> (-7.86%) ⬇️
internal/types/fjson/bool.go 42.85% <ø> (-2.60%) ⬇️
internal/types/fjson/datetime.go 45.45% <ø> (-13.81%) ⬇️
internal/types/fjson/document.go 64.86% <ø> (+12.23%) ⬆️
internal/types/fjson/double.go 80.00% <ø> (+5.00%) ⬆️
internal/types/fjson/fjson.go 86.36% <ø> (+1.74%) ⬆️
internal/types/fjson/int32.go 42.85% <ø> (-2.60%) ⬇️
internal/types/fjson/int64.go 55.55% <ø> (-8.45%) ⬇️
internal/types/fjson/null.go 66.66% <ø> (+26.66%) ⬆️
... and 7 more
Flag Coverage Δ
integration 62.67% <ø> (+1.57%) ⬆️
mongodb 14.16% <ø> (+0.33%) ⬆️
pg 52.17% <ø> (+1.30%) ⬆️
tigris 33.77% <ø> (+0.83%) ⬆️
unit 24.81% <ø> (-1.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@chilagrow chilagrow added the code/chore Code maintenance improvements label Oct 13, 2022
@vercel vercel bot temporarily deployed to Preview October 13, 2022 06:42 Inactive
@chilagrow chilagrow self-assigned this Oct 13, 2022
@chilagrow chilagrow added this to the v0.6.0 Alpha milestone Oct 13, 2022
@vercel vercel bot temporarily deployed to Preview October 13, 2022 06:52 Inactive
@chilagrow chilagrow requested review from a team, AlekSi, w84thesun, rumyantseva and noisersup and removed request for a team October 13, 2022 07:03
@chilagrow chilagrow marked this pull request as ready for review October 13, 2022 07:03
@chilagrow chilagrow requested a review from a team as a code owner October 13, 2022 07:03
AlekSi
AlekSi reviewed Oct 13, 2022
View reviewed changes
Copy link
Member

@AlekSi AlekSi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1254 (comment)

@vercel vercel bot temporarily deployed to Preview October 13, 2022 10:59 Inactive
w84thesun
w84thesun approved these changes Oct 13, 2022
View reviewed changes
Copy link
Contributor

@w84thesun w84thesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rumyantseva
rumyantseva approved these changes Oct 13, 2022
View reviewed changes
Copy link
Member

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vercel vercel bot temporarily deployed to Preview October 13, 2022 12:12 Inactive
@chilagrow chilagrow requested a review from AlekSi October 14, 2022 09:04
@chilagrow chilagrow enabled auto-merge (squash) October 14, 2022 09:13
@chilagrow chilagrow merged commit b45db81 into FerretDB:main Oct 14, 2022
AlekSi
AlekSi reviewed Oct 14, 2022
View reviewed changes
Copy link
Member

@AlekSi AlekSi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlekSi AlekSi AlekSi left review comments

@w84thesun w84thesun w84thesun approved these changes

@rumyantseva rumyantseva rumyantseva approved these changes

@noisersup noisersup noisersup approved these changes

Assignees

@chilagrow chilagrow

Labels
code/chore Code maintenance improvements
Projects
None yet
Milestone
v0.6.0 Alpha
Development

Successfully merging this pull request may close these issues.

Cleanup types/fjson package
6 participants
@chilagrow @CLAassistant @AlekSi @w84thesun @rumyantseva @noisersup