Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor handlers refactoring #1264

Merged
merged 1 commit into from
Oct 15, 2022
Merged

Minor handlers refactoring #1264

merged 1 commit into from
Oct 15, 2022

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Oct 15, 2022

Description

Do old TODO.

Readiness checklist

  • I added tests for new functionality or bugfixes.
  • I ran task all, and it passed.
  • I added/updated comments for both exported and unexported top-level declarations (functions, types, etc).
  • I checked comments rendering with task godocs.
  • I ensured that the title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Assignee, Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@vercel
Copy link

vercel bot commented Oct 15, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ferret-db ✅ Ready (Inspect) Visit Preview Oct 15, 2022 at 3:12PM (UTC)

@AlekSi AlekSi added this to the v0.6.0 Alpha milestone Oct 15, 2022
@AlekSi AlekSi added the code/chore Code maintenance improvements label Oct 15, 2022
@AlekSi AlekSi self-assigned this Oct 15, 2022
@vercel vercel bot temporarily deployed to Preview October 15, 2022 14:56 Inactive
@codecov
Copy link

codecov bot commented Oct 15, 2022

Codecov Report

Merging #1264 (9e0fffd) into main (b45db81) will decrease coverage by 0.14%.
The diff coverage is 86.95%.

❗ Current head 9e0fffd differs from pull request most recent head 254e39f. Consider uploading reports for the commit 254e39f to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1264      +/-   ##
==========================================
- Coverage   66.56%   66.41%   -0.15%     
==========================================
  Files         269      269              
  Lines       12575    12574       -1     
==========================================
- Hits         8370     8351      -19     
- Misses       3304     3316      +12     
- Partials      901      907       +6     
Impacted Files Coverage Δ
internal/handlers/pg/msg_createindexes.go 0.00% <0.00%> (ø)
internal/handlers/pg/msg_explain.go 0.00% <0.00%> (ø)
internal/handlers/pg/msg_hello.go 76.00% <0.00%> (ø)
internal/handlers/pg/msg_ismaster.go 76.00% <0.00%> (ø)
internal/handlers/pg/msg_ping.go 57.14% <0.00%> (ø)
internal/handlers/pg/msg_collstats.go 57.14% <100.00%> (ø)
internal/handlers/pg/msg_count.go 48.27% <100.00%> (ø)
internal/handlers/pg/msg_create.go 79.41% <100.00%> (ø)
internal/handlers/pg/msg_datasize.go 58.82% <100.00%> (ø)
internal/handlers/pg/msg_dbstats.go 65.11% <100.00%> (ø)
... and 15 more
Flag Coverage Δ
integration 62.66% <86.95%> (-0.15%) ⬇️
mongodb 14.16% <8.69%> (-0.05%) ⬇️
pg 52.17% <86.95%> (-0.15%) ⬇️
tigris 33.85% <0.00%> (-0.03%) ⬇️
unit 24.79% <2.17%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi changed the title Minor pg handler refactoring Minor handlers refactoring Oct 15, 2022
@AlekSi AlekSi marked this pull request as ready for review October 15, 2022 15:11
@AlekSi AlekSi requested a review from a team as a code owner October 15, 2022 15:11
@AlekSi AlekSi requested review from w84thesun, rumyantseva, a team, chilagrow and noisersup and removed request for a team October 15, 2022 15:11
@AlekSi AlekSi merged commit c363ece into FerretDB:main Oct 15, 2022
@AlekSi AlekSi deleted the embed-opts branch October 15, 2022 15:12
@vercel vercel bot temporarily deployed to Preview October 15, 2022 15:12 Inactive
@AlekSi
Copy link
Member Author

AlekSi commented Oct 15, 2022

Hm……

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant