Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make _id field required in data documents #1278

Merged
merged 23 commits into from Oct 21, 2022

Conversation

noisersup
Copy link
Member

@noisersup noisersup commented Oct 18, 2022

Description

This PR closes #1150.

Readiness checklist

  • I added tests for new functionality or bugfixes.
  • I ran task all, and it passed.
  • I added/updated comments for both exported and unexported top-level declarations (functions, types, etc).
  • I checked comments rendering with task godocs.
  • I ensured that the title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Assignee, Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@vercel
Copy link

vercel bot commented Oct 18, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ferret-db ✅ Ready (Inspect) Visit Preview Oct 21, 2022 at 10:27AM (UTC)

@vercel vercel bot temporarily deployed to Preview October 18, 2022 12:28 Inactive
@vercel vercel bot temporarily deployed to Preview October 19, 2022 10:58 Inactive
@vercel vercel bot temporarily deployed to Preview October 19, 2022 11:25 Inactive
@vercel vercel bot temporarily deployed to Preview October 19, 2022 13:11 Inactive
@noisersup noisersup self-assigned this Oct 19, 2022
@vercel vercel bot temporarily deployed to Preview October 19, 2022 13:20 Inactive
@vercel vercel bot temporarily deployed to Preview October 19, 2022 13:22 Inactive
@codecov
Copy link

codecov bot commented Oct 19, 2022

Codecov Report

Merging #1278 (4cc2f4b) into main (ea39dff) will increase coverage by 20.34%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #1278       +/-   ##
===========================================
+ Coverage   46.93%   67.28%   +20.34%     
===========================================
  Files         275      275               
  Lines       12857    12867       +10     
===========================================
+ Hits         6035     8658     +2623     
+ Misses       6095     3302     -2793     
- Partials      727      907      +180     
Impacted Files Coverage Δ
internal/types/document_validation.go 92.30% <100.00%> (+4.80%) ⬆️
internal/util/version/version.go 48.52% <0.00%> (-4.42%) ⬇️
internal/clientconn/conn.go 44.01% <0.00%> (+0.70%) ⬆️
integration/helpers.go 87.23% <0.00%> (+1.06%) ⬆️
internal/handlers/pg/pgdb/collections.go 50.00% <0.00%> (+2.27%) ⬆️
internal/handlers/pg/pgdb/settings.go 39.53% <0.00%> (+2.32%) ⬆️
internal/handlers/pg/pgdb/tables.go 64.70% <0.00%> (+2.94%) ⬆️
internal/handlers/pg/pgdb/databases.go 55.00% <0.00%> (+5.00%) ⬆️
internal/handlers/common/limit.go 75.00% <0.00%> (+8.33%) ⬆️
... and 50 more
Flag Coverage Δ
integration 62.81% <77.77%> (+25.49%) ⬆️
mongodb 14.15% <0.00%> (-0.04%) ⬇️
pg 52.33% <77.77%> (?)
tigris 34.71% <77.77%> (+<0.01%) ⬆️
unit 25.69% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@vercel vercel bot temporarily deployed to Preview October 19, 2022 19:16 Inactive
@vercel vercel bot temporarily deployed to Preview October 19, 2022 19:24 Inactive
@noisersup noisersup added the trust PRs that can access Actions secrets label Oct 19, 2022
@noisersup noisersup removed the trust PRs that can access Actions secrets label Oct 19, 2022
@vercel vercel bot temporarily deployed to Preview October 19, 2022 19:28 Inactive
@vercel vercel bot temporarily deployed to Preview October 19, 2022 19:33 Inactive
@vercel vercel bot temporarily deployed to Preview October 19, 2022 20:00 Inactive
Co-authored-by: Elena Grahovac <elena@grahovac.me>
@vercel vercel bot temporarily deployed to Preview October 20, 2022 13:41 Inactive
rumyantseva
rumyantseva previously approved these changes Oct 20, 2022
Copy link
Member

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vercel vercel bot temporarily deployed to Preview October 20, 2022 14:36 Inactive
@vercel vercel bot temporarily deployed to Preview October 20, 2022 15:00 Inactive
@vercel vercel bot temporarily deployed to Preview October 20, 2022 15:14 Inactive
Copy link
Member

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good to me, but I have one idea to discuss with everyone :)

internal/types/document_validation.go Show resolved Hide resolved
w84thesun
w84thesun previously approved these changes Oct 21, 2022
Copy link
Contributor

@w84thesun w84thesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vercel vercel bot temporarily deployed to Preview October 21, 2022 09:24 Inactive
@vercel vercel bot temporarily deployed to Preview October 21, 2022 10:27 Inactive
@AlekSi AlekSi enabled auto-merge (squash) October 21, 2022 10:45
Copy link
Member

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlekSi AlekSi merged commit 0a8f401 into FerretDB:main Oct 21, 2022
@noisersup noisersup deleted the require-id-1150 branch October 21, 2022 11:30
@AlekSi AlekSi added this to the v0.6.0 Alpha milestone Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/enhancement Some user-visible feature could work better
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make _id field required in data documents
5 participants