New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate infinity values in data documents #1296
Deprecate infinity values in data documents #1296
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1296 +/- ##
==========================================
- Coverage 67.19% 67.16% -0.04%
==========================================
Files 276 276
Lines 13021 13024 +3
==========================================
- Hits 8750 8748 -2
- Misses 3349 3353 +4
- Partials 922 923 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't get an answer to the questions from my past review:
- when will we update diff.md
- when will we add dance tests
It is impossible to do that in this PR.
When we will be back working on this issue. That PR is good enough otherwise. It does not close the issue. |
@rumyantseva Added checkbox about dance tests inside issue's description |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the questions are answered, and the code looks good to me.
Description
This PR is a part of the #1151.
Readiness checklist
task all
, and it passed.task godocs
.@FerretDB/core
), Assignee, Labels, Project and project's Sprint fields.