Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate infinity values in data documents #1296

Merged
merged 21 commits into from Oct 25, 2022

Conversation

noisersup
Copy link
Member

@noisersup noisersup commented Oct 20, 2022

Description

This PR is a part of the #1151.

Readiness checklist

  • I added tests for new functionality or bugfixes.
  • I ran task all, and it passed.
  • I added/updated comments for both exported and unexported top-level declarations (functions, types, etc).
  • I checked comments rendering with task godocs.
  • I ensured that the title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Assignee, Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@noisersup noisersup self-assigned this Oct 20, 2022
@vercel
Copy link

vercel bot commented Oct 20, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ferret-db ✅ Ready (Inspect) Visit Preview Oct 24, 2022 at 11:47AM (UTC)

@noisersup noisersup added the code/feature Some user-visible feature is not implemented yet label Oct 20, 2022
@vercel vercel bot temporarily deployed to Preview October 20, 2022 22:39 Inactive
@codecov
Copy link

codecov bot commented Oct 20, 2022

Codecov Report

Merging #1296 (56ad777) into main (e757e4b) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1296      +/-   ##
==========================================
- Coverage   67.19%   67.16%   -0.04%     
==========================================
  Files         276      276              
  Lines       13021    13024       +3     
==========================================
- Hits         8750     8748       -2     
- Misses       3349     3353       +4     
- Partials      922      923       +1     
Impacted Files Coverage Δ
integration/shareddata/scalars.go 100.00% <ø> (ø)
internal/types/document_validation.go 93.10% <100.00%> (+0.79%) ⬆️
internal/util/version/version.go 48.52% <0.00%> (-4.42%) ⬇️
internal/types/path.go 87.00% <0.00%> (-1.00%) ⬇️
internal/handlers/common/filter.go 87.37% <0.00%> (ø)
Flag Coverage Δ
integration 63.07% <50.00%> (-0.12%) ⬇️
mongodb 14.10% <0.00%> (-0.05%) ⬇️
pg 52.61% <50.00%> (-0.12%) ⬇️
tigris 34.51% <50.00%> (-0.04%) ⬇️
unit 25.48% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@vercel vercel bot temporarily deployed to Preview October 20, 2022 22:48 Inactive
@vercel vercel bot temporarily deployed to Preview October 20, 2022 22:53 Inactive
internal/types/document.go Outdated Show resolved Hide resolved
@noisersup noisersup changed the title Deprecate NaNs and infinity values in data and command documents Deprecate infinity values in data documents Oct 21, 2022
@vercel vercel bot temporarily deployed to Preview October 21, 2022 08:25 Inactive
@vercel vercel bot temporarily deployed to Preview October 21, 2022 08:29 Inactive
@noisersup noisersup linked an issue Oct 21, 2022 that may be closed by this pull request
1 task
@vercel vercel bot temporarily deployed to Preview October 21, 2022 10:05 Inactive
@vercel vercel bot temporarily deployed to Preview October 21, 2022 14:27 Inactive
@AlekSi AlekSi added this to the v0.6.0 Alpha milestone Oct 21, 2022
@vercel vercel bot temporarily deployed to Preview October 21, 2022 14:58 Inactive
@vercel vercel bot temporarily deployed to Preview October 21, 2022 16:38 Inactive
@vercel vercel bot temporarily deployed to Preview October 21, 2022 17:18 Inactive
@vercel vercel bot temporarily deployed to Preview October 24, 2022 02:32 Inactive
@vercel vercel bot temporarily deployed to Preview October 24, 2022 02:47 Inactive
chilagrow
chilagrow previously approved these changes Oct 24, 2022
Copy link
Contributor

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@vercel vercel bot temporarily deployed to Preview October 24, 2022 07:58 Inactive
@vercel vercel bot temporarily deployed to Preview October 24, 2022 08:11 Inactive
@vercel vercel bot temporarily deployed to Preview October 24, 2022 09:11 Inactive
@vercel vercel bot temporarily deployed to Preview October 24, 2022 10:37 Inactive
@vercel vercel bot temporarily deployed to Preview October 24, 2022 10:43 Inactive
@vercel vercel bot temporarily deployed to Preview October 24, 2022 11:47 Inactive
Copy link
Member

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't get an answer to the questions from my past review:

  • when will we update diff.md
  • when will we add dance tests

@AlekSi
Copy link
Member

AlekSi commented Oct 24, 2022

when will we add dance tests

It is impossible to do that in this PR.

when will we update diff.md

When we will be back working on this issue.

That PR is good enough otherwise. It does not close the issue.

@noisersup
Copy link
Member Author

@rumyantseva Added checkbox about dance tests inside issue's description

Copy link
Member

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the questions are answered, and the code looks good to me.

@rumyantseva rumyantseva merged commit 38b30b5 into FerretDB:main Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/feature Some user-visible feature is not implemented yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validate command documents after reading them from the wire
5 participants