Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add basic telemetry #1299

Merged
merged 12 commits into from Oct 24, 2022
Merged

Add basic telemetry #1299

merged 12 commits into from Oct 24, 2022

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Oct 21, 2022 •
edited

Readiness checklist

  • I added tests for new functionality or bugfixes.
  • I ran task all, and it passed.
  • I added/updated comments for both exported and unexported top-level declarations (functions, types, etc).
  • I checked comments rendering with task godocs.
  • I ensured that the title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Assignee, Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi self-assigned this Oct 21, 2022
@vercel
Copy link

vercel bot commented Oct 21, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ferret-db ✅ Ready (Inspect) Visit Preview Oct 24, 2022 at 9:15AM (UTC)

@vercel vercel bot temporarily deployed to Preview October 21, 2022 15:54 Inactive
@vercel vercel bot temporarily deployed to Preview October 22, 2022 11:57 Inactive
@vercel vercel bot temporarily deployed to Preview October 23, 2022 12:11 Inactive
@vercel vercel bot temporarily deployed to Preview October 23, 2022 12:14 Inactive
@vercel vercel bot temporarily deployed to Preview October 23, 2022 12:21 Inactive
@codecov
Copy link

codecov bot commented Oct 23, 2022 •
edited

Codecov Report

Merging #1299 (784c6b3) into main (fcf3fbd) will decrease coverage by 0.65%.
The diff coverage is 8.08%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1299      +/-   ##
==========================================
- Coverage   67.87%   67.22%   -0.66%     
==========================================
  Files         275      276       +1     
  Lines       12888    13021     +133     
==========================================
+ Hits         8748     8753       +5     
- Misses       3218     3344     +126     
- Partials      922      924       +2
Impacted Files Coverage Δ
...nternal/clientconn/connmetrics/listener_metrics.go 72.41% <ø> (ø)
internal/util/telemetry/telemetry.go 0.00% <0.00%> (ø)
internal/util/state/metrics.go 88.23% <60.00%> (-11.77%) ⬇️
internal/util/state/state.go 83.33% <62.50%> (-16.67%) ⬇️
internal/util/version/version.go 48.52% <0.00%> (-4.42%) ⬇️
internal/handlers/common/filter.go 87.37% <0.00%> (ø)
Flag Coverage Δ
integration 63.21% <27.77%> (-0.08%) ⬇️
mongodb 14.11% <0.00%> (-0.06%) ⬇️
pg 52.75% <27.77%> (-0.07%) ⬇️
tigris 34.52% <27.77%> (-0.05%) ⬇️
unit 25.47% <8.08%> (-0.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@vercel vercel bot temporarily deployed to Preview October 23, 2022 12:42 Inactive
@vercel vercel bot temporarily deployed to Preview October 23, 2022 13:14 Inactive
AlekSi
AlekSi commented Oct 23, 2022
View reviewed changes
.golangci.yml Show resolved Hide resolved
@AlekSi AlekSi changed the title Basic telemetry Add basic telemetry Oct 23, 2022
@AlekSi AlekSi added the code/feature Some user-visible feature is not implemented yet label Oct 24, 2022
@AlekSi AlekSi marked this pull request as ready for review October 24, 2022 05:00
@AlekSi AlekSi requested a review from a team as a code owner October 24, 2022 05:00
@AlekSi AlekSi requested review from w84thesun, rumyantseva, a team, chilagrow and noisersup and removed request for a team October 24, 2022 05:00
@AlekSi AlekSi enabled auto-merge (squash) October 24, 2022 05:01
chilagrow
chilagrow previously approved these changes Oct 24, 2022
View reviewed changes
Copy link
Contributor

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

internal/util/telemetry/telemetry.go Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview October 24, 2022 07:58 Inactive
@vercel vercel bot temporarily deployed to Preview October 24, 2022 08:09 Inactive
rumyantseva
rumyantseva reviewed Oct 24, 2022
View reviewed changes
Copy link
Member

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM to me overall. I asked a few questions.

internal/util/telemetry/telemetry.go Outdated Show resolved Hide resolved
internal/util/telemetry/telemetry.go Show resolved Hide resolved
internal/util/telemetry/telemetry.go Show resolved Hide resolved
cmd/ferretdb/main.go Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview October 24, 2022 09:07 Inactive
@AlekSi @rumyantseva
Update internal/util/telemetry/telemetry.go
784c6b3 
Co-authored-by: Elena Grahovac <elena@grahovac.me>
@vercel vercel bot temporarily deployed to Preview October 24, 2022 09:16 Inactive
rumyantseva
rumyantseva approved these changes Oct 24, 2022
View reviewed changes
Copy link
Member

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No new questions. LGTM

@AlekSi
Copy link
Member Author

AlekSi commented Oct 24, 2022

@chilagrow PTAL

@AlekSi AlekSi requested review from a team October 24, 2022 10:26
@AlekSi AlekSi disabled auto-merge October 24, 2022 10:39
@AlekSi AlekSi merged commit e0635a3 into FerretDB:main Oct 24, 2022
@AlekSi AlekSi deleted the basic-telemetry branch October 24, 2022 10:39
@AlekSi AlekSi added this to the v0.6.0 Alpha milestone Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rumyantseva rumyantseva rumyantseva approved these changes

@w84thesun w84thesun Awaiting requested review from w84thesun w84thesun is a code owner automatically assigned from FerretDB/leads

@noisersup noisersup Awaiting requested review from noisersup noisersup was automatically assigned from FerretDB/core

@chilagrow chilagrow Awaiting requested review from chilagrow

Assignees

@AlekSi AlekSi

Labels
code/feature Some user-visible feature is not implemented yet
Projects
None yet
Milestone
v0.6.0 Alpha
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AlekSi @rumyantseva @chilagrow