Allow dashes (-) in collection names

[noisersup]

Description

Closes #1280 .

Readiness checklist

• I added tests for new functionality or bugfixes.
• I ran task all, and it passed.
• I added/updated comments for both exported and unexported top-level declarations (functions, types, etc).
• I checked comments rendering with task godocs.
• I ensured that the title is good enough for the changelog.
• (for maintainers only) I set Reviewers (@FerretDB/core), Assignee, Labels, Project and project's Sprint fields.
• I marked all done items in this checklist.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
ferret-db	✅ Ready (Inspect)	Visit Preview	Oct 25, 2022 at 4:53PM (UTC)

[codecov]

Codecov Report

Merging #1312 (03bd269) into main (1df8ad6) will increase coverage by 20.60%.
The diff coverage is n/a.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #1312       +/-   ##
===========================================
+ Coverage   46.82%   67.42%   +20.60%     
===========================================
  Files         279      279               
  Lines       13100    13100               
===========================================
+ Hits         6134     8833     +2699     
+ Misses       6231     3342     -2889     
- Partials      735      925      +190     

Impacted Files	Coverage Δ
internal/handlers/pg/pgdb/collections.go	50.00% <ø> (+2.27%)	⬆️
internal/handlers/pg/pgdb/databases.go	55.00% <ø> (+5.00%)	⬆️
internal/util/version/version.go	48.52% <0.00%> (-4.42%)	⬇️
internal/clientconn/conn.go	44.01% <0.00%> (+0.70%)	⬆️
integration/helpers.go	87.23% <0.00%> (+1.06%)	⬆️
internal/handlers/pg/pgdb/tables.go	64.70% <0.00%> (+2.94%)	⬆️
internal/handlers/pg/pgdb/settings.go	44.18% <0.00%> (+6.97%)	⬆️
internal/handlers/common/limit.go	75.00% <0.00%> (+8.33%)	⬆️
... and 51 more

Flag	Coverage Δ
integration	63.33% <ø> (+25.98%)	⬆️
mongodb	14.23% <ø> (-0.03%)	⬇️
pg	52.89% <ø> (?)
tigris	34.73% <ø> (-0.03%)	⬇️
unit	25.86% <ø> (-0.03%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

[noisersup]

We don't check for dashes inside the dance tests so I'm not sure what should we change there

[rumyantseva]

The code looks good to me in general.
I remember, at planning, we were discussing if we should start using dashes instead of undescores in CollectionName testutil's handler -

FerretDB/internal/util/testutil/db.go

Line 92 in 74d6f83

func CollectionName(tb testing.TB) string {

. So, you decided not doing it?

[noisersup]

@rumyantseva I was confused about this part and thought that discussion and mention about this function was only because it would not work correctly. Now, I can see that the point of this change is different. Do we finally prefer using underscores there or dashes?

[rumyantseva]

@noisersup I think the idea was to have more test cases. Personally, I'm ok with either dashes or underscores.

[rumyantseva]

LGTM as everything is tested.