Deprecate dotted fields in data documents #1313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
October 13, 2022 12:13
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1313 +/- ##
==========================================
- Coverage 67.15% 67.13% -0.02%
==========================================
Files 279 279
Lines 13131 13134 +3
==========================================
Hits 8818 8818
- Misses 3388 3390 +2
- Partials 925 926 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
added 3 commits
October 26, 2022 12:17
…s' into issue-659-deprecate-dotted-fields
w84thesun
requested review from
AlekSi,
Fashander,
rumyantseva and
a team
and removed request for
rumyantseva and
a team
rumyantseva
requested changes
Oct 27, 2022
There was a problem hiding this comment.
One tiny thing in the documentation.
Also, please note that dance tests need to be added for . and modified for $ as you modified the error message. (Personally, I don't think that the word sign is really needed in error messages, but I leave it up to you).
Dance tests are here: https://github.com/FerretDB/dance/blob/main/tests/diff/document_validation_test.go
added 2 commits
October 27, 2022 14:29
…s' into issue-659-deprecate-dotted-fields
AlekSi
reviewed
Oct 27, 2022
chilagrow
approved these changes
Oct 28, 2022
AlekSi
approved these changes
Oct 28, 2022
Closed
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #659.
Readiness checklist
task all, and it passed.task godocs.@FerretDB/core), Assignee, Labels, Project and project's Sprint fields.