Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add stress tests for settings table and fix simple issues with transactions #1316
Add stress tests for settings table and fix simple issues with transactions #1316
Changes from 39 commits
82a45b2
4755005
4670e24
73df1d5
92059f7
800b270
5505f2b
83191c1
a4411e9
66f764b
db1a855
e38f107
36adb81
441794c
ce526b0
a3db999
1cca2f8
a09782c
185ee71
befd734
e269086
8e0b6b8
9b31a70
e7348d3
85fe3bd
03bc222
38aa9de
bc8a7d3
d65d58b
cf994f0
807d546
441b36e
81095c3
a3c1deb
6c65dfe
fba8f08
155a8f9
5a7a766
0b0c662
42fa253
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have the same comment there and at #1318 (comment), but the implementation of error checking is very different. Which one is correct?