Add stress tests for settings table and fix simple issues with transactions #1316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
2 tasks
rumyantseva
changed the title
2 tasks
rumyantseva
changed the title
rumyantseva
requested review from
AlekSi,
w84thesun,
a team,
chilagrow and
noisersup
and removed request for
a team
AlekSi
previously approved these changes
Oct 28, 2022
chilagrow
approved these changes
Oct 31, 2022
noisersup
approved these changes
Oct 31, 2022
AlekSi
reviewed
Nov 1, 2022
| if err != nil { | ||
| var cmdErr *mongo.CommandError | ||
| if errors.As(err, &cmdErr) { | ||
| if strings.Contains(cmdErr.Message, `unknown top level operator: $tigrisSchemaString`) { |
There was a problem hiding this comment.
We have the same comment there and at #1318 (comment), but the implementation of error checking is very different. Which one is correct?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #1282.
See also my comments in the original issue.
See also #1318 for
SchemaStatsrelated issues.Readiness checklist
task all, and it passed.task godocs.@FerretDB/core), Assignee, Labels, Project and project's Sprint fields.