Forbid regex types and arrays in document's _id field
#1326
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1326 +/- ##
===========================================
+ Coverage 46.63% 67.37% +20.74%
===========================================
Files 279 279
Lines 13134 13141 +7
===========================================
+ Hits 6125 8854 +2729
+ Misses 6273 3365 -2908
- Partials 736 922 +186
Flags with carried forward coverage won't be shown. Click here to find out more. |
noisersup
changed the title
_id field_id field
|
Need a help with a linter. It screams about deprecation because of generating files, though we don't have any quick alternatives to the |
| var targetFindRes, compatFindRes bson.D | ||
| targetCur, err := targetCollection.Find(ctx, bson.D{{}}) | ||
| require.NoError(t, err) | ||
| targetCur.Decode(&targetFindRes) | ||
|
|
||
| compatCur, err := compatCollection.Find(ctx, bson.D{{}}) | ||
| require.NoError(t, err) | ||
| compatCur.Decode(&targetFindRes) | ||
|
|
||
| AssertEqualDocuments(t, compatFindRes, targetFindRes) |
There was a problem hiding this comment.
Should we find by _id to compare inserted documents here? (The idea is to check that what we inserted is really stored equally).
There was a problem hiding this comment.
I think that checking whole collection content is much more full-bodied. What if the insert function misbehaves and creates additional entry in collection? Checking only for specific _id would not cover this case
Description
Closes #1235.
Readiness checklist
task all, and it passed.task godocs.@FerretDB/core), Assignee, Labels, Project and project's Sprint fields.