Update some TODOs #1452
Merged
Update some TODOs #1452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
AlekSi
requested review from
a team,
chilagrow and
noisersup
and removed request for
a team
rumyantseva
reviewed
Nov 16, 2022
There was a problem hiding this comment.
LGTM overall, one thing is already covered in https://github.com/FerretDB/FerretDB/pull/1391/files and doesn't need to be mentioned here.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1452 +/- ##
==========================================
- Coverage 67.82% 67.67% -0.16%
==========================================
Files 279 279
Lines 13487 13487
==========================================
- Hits 9148 9127 -21
- Misses 3417 3435 +18
- Partials 922 925 +3
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Deployment failed with the following error: |
chilagrow
previously approved these changes
Nov 17, 2022
|
Deployment failed with the following error: |
|
Deployment failed with the following error: |
|
Deployment failed with the following error: |
w84thesun
previously approved these changes
Nov 17, 2022
# Conflicts: # integration/update_field_compat_test.go
AlekSi
requested review from
rumyantseva,
w84thesun,
chilagrow,
noisersup and
a team
w84thesun
approved these changes
Nov 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Readiness checklist
task all, and it passed.task godocs.@FerretDB/core), Assignee, Labels, Project and project's Sprint fields.