Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify documents fetching for find, findAndModify, and update #1538

Merged
merged 107 commits into from
Nov 30, 2022

Conversation

rumyantseva
Copy link
Member

@rumyantseva rumyantseva commented Nov 22, 2022

Description

Closes #898.

Readiness checklist

  • I added tests for new functionality or bugfixes.
  • I ran task all, and it passed.
  • I added/updated comments for both exported and unexported top-level declarations (functions, types, etc).
  • I checked comments rendering with task godocs.
  • I ensured that the title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Assignee, Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@vercel vercel bot temporarily deployed to Preview November 29, 2022 17:03 Inactive
@vercel vercel bot temporarily deployed to Preview November 29, 2022 17:12 Inactive
@rumyantseva rumyantseva marked this pull request as ready for review November 29, 2022 17:14
@rumyantseva rumyantseva requested a review from a team as a code owner November 29, 2022 17:14
@rumyantseva rumyantseva enabled auto-merge (squash) November 29, 2022 17:14
@rumyantseva rumyantseva requested review from a team, chilagrow and noisersup and removed request for a team November 29, 2022 17:15
@AlekSi AlekSi added this to the v0.7.0 milestone Nov 29, 2022
@vercel vercel bot temporarily deployed to Preview November 30, 2022 00:53 Inactive
@vercel vercel bot temporarily deployed to Preview November 30, 2022 06:08 Inactive
chilagrow
chilagrow previously approved these changes Nov 30, 2022
@AlekSi
Copy link
Member

AlekSi commented Nov 30, 2022

@rumyantseva there are conflicts now

@rumyantseva
Copy link
Member Author

@AlekSi fixed

@vercel vercel bot temporarily deployed to Preview November 30, 2022 07:53 Inactive
@rumyantseva rumyantseva merged commit 0a63e58 into FerretDB:main Nov 30, 2022
@rumyantseva rumyantseva deleted the issue-898-leftovers branch November 30, 2022 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Offer a better design for fetching documents (iterator)
4 participants