Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve iterator.Interface implementation in pgdb.queryIterator #1592

Merged
merged 13 commits into from
Nov 30, 2022

Conversation

rumyantseva
Copy link
Member

@rumyantseva rumyantseva commented Nov 29, 2022

Description

Closes #898.

Readiness checklist

  • I added tests for new functionality or bugfixes.
  • I ran task all, and it passed.
  • I added/updated comments for both exported and unexported top-level declarations (functions, types, etc).
  • I checked comments rendering with task godocs.
  • I ensured that the title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Assignee, Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@rumyantseva rumyantseva added the code/chore Code maintenance improvements label Nov 29, 2022
@rumyantseva rumyantseva self-assigned this Nov 29, 2022
@vercel
Copy link

vercel bot commented Nov 29, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ferret-db ✅ Ready (Inspect) Visit Preview Nov 30, 2022 at 10:36AM (UTC)

@rumyantseva rumyantseva added the do not merge PRs that should not be merged label Nov 29, 2022
@vercel vercel bot temporarily deployed to Preview November 29, 2022 15:43 Inactive
@rumyantseva
Copy link
Member Author

This PR is to check a particular design/implementation idea proposed by @AlekSi, so, @AlekSi's review is required and this is why "do not merge" label is set.

@AlekSi
Copy link
Member

AlekSi commented Nov 29, 2022

I think that comment should be in the PR body before description

@vercel vercel bot temporarily deployed to Preview November 29, 2022 16:20 Inactive
@vercel vercel bot temporarily deployed to Preview November 29, 2022 16:27 Inactive
@rumyantseva rumyantseva marked this pull request as ready for review November 29, 2022 16:28
@rumyantseva rumyantseva requested a review from a team as a code owner November 29, 2022 16:28
@rumyantseva rumyantseva enabled auto-merge (squash) November 29, 2022 16:28
@rumyantseva rumyantseva requested review from a team, chilagrow and noisersup and removed request for a team November 29, 2022 16:28
@rumyantseva rumyantseva changed the title Improve iterator.Interface implementation for pgdb.queryIterator Improve iterator.Interface implementation in pgdb.queryIterator Nov 29, 2022
@codecov
Copy link

codecov bot commented Nov 29, 2022

Codecov Report

Merging #1592 (675c190) into main (0a63e58) will decrease coverage by 0.10%.
The diff coverage is 91.66%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1592      +/-   ##
==========================================
- Coverage   68.03%   67.93%   -0.11%     
==========================================
  Files         285      285              
  Lines       13670    13655      -15     
==========================================
- Hits         9301     9277      -24     
- Misses       3435     3442       +7     
- Partials      934      936       +2     
Impacted Files Coverage Δ
internal/handlers/pg/msg_delete.go 69.68% <ø> (-0.64%) ⬇️
internal/handlers/pg/msg_find.go 76.28% <ø> (-0.72%) ⬇️
internal/handlers/pg/pgdb/query_iterator.go 76.47% <90.90%> (-4.49%) ⬇️
internal/handlers/pg/pgdb/query.go 72.00% <100.00%> (ø)
internal/util/version/version.go 48.52% <0.00%> (-4.42%) ⬇️
internal/clientconn/conn.go 44.02% <0.00%> (-2.63%) ⬇️
internal/clientconn/listener.go 80.64% <0.00%> (-2.42%) ⬇️
internal/handlers/common/filter.go 85.43% <0.00%> (+0.58%) ⬆️
Flag Coverage Δ
integration 63.89% <91.66%> (-0.09%) ⬇️
mongodb 14.10% <0.00%> (+<0.01%) ⬆️
pg 52.68% <91.66%> (-0.10%) ⬇️
tigris 37.51% <0.00%> (+0.01%) ⬆️
unit 26.76% <83.33%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@vercel vercel bot temporarily deployed to Preview November 29, 2022 16:33 Inactive
@vercel vercel bot temporarily deployed to Preview November 30, 2022 00:54 Inactive
@vercel vercel bot temporarily deployed to Preview November 30, 2022 06:11 Inactive
chilagrow
chilagrow previously approved these changes Nov 30, 2022
@vercel vercel bot temporarily deployed to Preview November 30, 2022 07:48 Inactive
Copy link
Contributor

@w84thesun w84thesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, it will make usage of iterator easier! Please resolve conflicts.

AlekSi
AlekSi previously approved these changes Nov 30, 2022
integration/update_field_test.go Show resolved Hide resolved
internal/handlers/pg/pgdb/query_iterator.go Outdated Show resolved Hide resolved
internal/handlers/pg/pgdb/query_iterator.go Outdated Show resolved Hide resolved
@rumyantseva rumyantseva dismissed stale reviews from AlekSi and chilagrow via 2b92bd6 November 30, 2022 10:19
rumyantseva and others added 3 commits November 30, 2022 11:20
Co-authored-by: Alexey Palazhchenko <alexey.palazhchenko@gmail.com>
@vercel vercel bot temporarily deployed to Preview November 30, 2022 10:24 Inactive
@vercel vercel bot temporarily deployed to Preview November 30, 2022 10:36 Inactive
@rumyantseva rumyantseva removed the do not merge PRs that should not be merged label Nov 30, 2022
@rumyantseva rumyantseva merged commit 5efc745 into FerretDB:main Nov 30, 2022
@rumyantseva rumyantseva deleted the issue-898-empty-iterator branch November 30, 2022 11:04
@AlekSi AlekSi added this to the v0.7.0 milestone Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Offer a better design for fetching documents (iterator)
4 participants