Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TODOs #1595

Merged
merged 2 commits into from
Nov 30, 2022
Merged

Add TODOs #1595

merged 2 commits into from
Nov 30, 2022

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Nov 29, 2022

Readiness checklist

  • I added tests for new functionality or bugfixes.
  • I ran task all, and it passed.
  • I added/updated comments for both exported and unexported top-level declarations (functions, types, etc).
  • I checked comments rendering with task godocs.
  • I ensured that the title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Assignee, Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added the code/chore Code maintenance improvements label Nov 29, 2022
@AlekSi AlekSi added this to the v0.7.0 milestone Nov 29, 2022
@AlekSi AlekSi self-assigned this Nov 29, 2022
@vercel
Copy link

vercel bot commented Nov 29, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ferret-db ✅ Ready (Inspect) Visit Preview Nov 30, 2022 at 0:50AM (UTC)

@vercel vercel bot temporarily deployed to Preview November 29, 2022 17:04 Inactive
@codecov
Copy link

codecov bot commented Nov 29, 2022

Codecov Report

Merging #1595 (66bd49b) into main (3cdd0be) will decrease coverage by 0.20%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1595      +/-   ##
==========================================
- Coverage   67.74%   67.53%   -0.21%     
==========================================
  Files         284      284              
  Lines       13813    13825      +12     
==========================================
- Hits         9357     9337      -20     
- Misses       3499     3530      +31     
- Partials      957      958       +1     
Impacted Files Coverage Δ
ferretdb/ferretdb.go 80.28% <100.00%> (ø)
integration/setup/common.go 94.24% <100.00%> (+0.39%) ⬆️
integration/setup/common_unix.go 86.48% <100.00%> (+1.19%) ⬆️
internal/handlers/tigris/tigrisdb/errors.go 21.42% <0.00%> (-21.43%) ⬇️
internal/handlers/tigris/tigrisdb/databases.go 57.50% <0.00%> (-10.00%) ⬇️
internal/handlers/tigris/msg_create.go 67.60% <0.00%> (-7.05%) ⬇️
internal/handlers/tigris/tigrisdb/collections.go 61.90% <0.00%> (-4.77%) ⬇️
internal/util/version/version.go 48.52% <0.00%> (-4.42%) ⬇️
internal/handlers/pg/pgdb/collections.go 52.27% <0.00%> (-2.28%) ⬇️
internal/handlers/pg/pgdb/settings.go 44.21% <0.00%> (-2.05%) ⬇️
... and 1 more
Flag Coverage Δ
integration 63.46% <92.85%> (-0.21%) ⬇️
mongodb 13.90% <28.57%> (-0.01%) ⬇️
pg 52.34% <92.85%> (-0.07%) ⬇️
tigris 36.80% <50.00%> (-0.13%) ⬇️
unit 26.79% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi marked this pull request as ready for review November 29, 2022 17:16
@AlekSi AlekSi requested a review from a team as a code owner November 29, 2022 17:16
@AlekSi AlekSi requested review from w84thesun, rumyantseva, a team, chilagrow and noisersup and removed request for a team November 29, 2022 17:16
Copy link
Member

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vercel vercel bot temporarily deployed to Preview November 30, 2022 00:50 Inactive
@AlekSi AlekSi enabled auto-merge (squash) November 30, 2022 05:52
@AlekSi AlekSi merged commit d521344 into FerretDB:main Nov 30, 2022
@AlekSi AlekSi deleted the todos branch November 30, 2022 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants