Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compare unit tests for edge cases #1624

Merged
merged 6 commits into from
Dec 6, 2022

Conversation

chilagrow
Copy link
Contributor

@chilagrow chilagrow commented Dec 6, 2022

Description

Closes #1616.

Readiness checklist

  • I added tests for new functionality or bugfixes.
  • I ran task all, and it passed.
  • I added/updated comments for both exported and unexported top-level declarations (functions, types, etc).
  • I checked comments rendering with task godocs.
  • I ensured that the title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Assignee, Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@chilagrow chilagrow added the code/chore Code maintenance improvements label Dec 6, 2022
@chilagrow chilagrow self-assigned this Dec 6, 2022
@vercel
Copy link

vercel bot commented Dec 6, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ferret-db ✅ Ready (Inspect) Visit Preview Dec 6, 2022 at 9:13AM (UTC)

@vercel vercel bot temporarily deployed to Preview December 6, 2022 03:29 Inactive
@vercel vercel bot temporarily deployed to Preview December 6, 2022 03:30 Inactive
@codecov
Copy link

codecov bot commented Dec 6, 2022

Codecov Report

Merging #1624 (7e0a588) into main (8521c1e) will decrease coverage by 0.23%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1624      +/-   ##
==========================================
- Coverage   68.18%   67.95%   -0.24%     
==========================================
  Files         285      285              
  Lines       13766    13766              
==========================================
- Hits         9387     9355      -32     
- Misses       3443     3466      +23     
- Partials      936      945       +9     
Impacted Files Coverage Δ
internal/handlers/pg/msg_create.go 77.21% <0.00%> (-6.33%) ⬇️
internal/util/version/version.go 70.58% <0.00%> (-4.42%) ⬇️
integration/setup/common.go 91.36% <0.00%> (-2.88%) ⬇️
internal/clientconn/conn.go 44.02% <0.00%> (-2.63%) ⬇️
internal/clientconn/listener.go 80.64% <0.00%> (-2.42%) ⬇️
internal/handlers/pg/pgdb/collections.go 52.27% <0.00%> (-2.28%) ⬇️
integration/setup/setup_compat.go 83.21% <0.00%> (-2.19%) ⬇️
internal/handlers/pg/pgdb/settings.go 44.21% <0.00%> (-2.05%) ⬇️
integration/setup/setup.go 85.47% <0.00%> (-1.71%) ⬇️
internal/handlers/common/filter.go 84.68% <0.00%> (-0.28%) ⬇️
... and 1 more
Flag Coverage Δ
integration 63.92% <ø> (-0.24%) ⬇️
mongodb ?
pg 52.87% <ø> (-0.17%) ⬇️
tigris 37.28% <ø> (-0.03%) ⬇️
unit 26.82% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@vercel vercel bot temporarily deployed to Preview December 6, 2022 05:41 Inactive
@chilagrow chilagrow marked this pull request as ready for review December 6, 2022 05:42
@chilagrow chilagrow requested a review from a team as a code owner December 6, 2022 05:42
@chilagrow chilagrow requested review from AlekSi, w84thesun, rumyantseva, a team and noisersup and removed request for a team December 6, 2022 05:42
@chilagrow chilagrow enabled auto-merge (squash) December 6, 2022 05:43
@vercel vercel bot temporarily deployed to Preview December 6, 2022 05:52 Inactive
Copy link
Member

@AlekSi AlekSi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add some test that is not skipped to ensure that it works

@vercel vercel bot temporarily deployed to Preview December 6, 2022 08:14 Inactive
@vercel vercel bot temporarily deployed to Preview December 6, 2022 09:13 Inactive
@chilagrow chilagrow requested a review from AlekSi December 6, 2022 09:20
Copy link
Member

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm glad we have more clarity with these test cases! 👍

@chilagrow chilagrow merged commit 73761a7 into FerretDB:main Dec 6, 2022
@AlekSi AlekSi added this to the v0.7.1 milestone Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add unit tests for types.Compare
4 participants