Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add section for comparison and logical query operators #1647

Merged
merged 16 commits into from Dec 21, 2022

Conversation

Fashander
Copy link
Member

@Fashander Fashander commented Dec 14, 2022

Description

Closes #1314.

Readiness checklist

  • I added tests for new functionality or bugfixes.
  • I ran task all, and it passed.
  • I added/updated comments for both exported and unexported top-level declarations (functions, types, etc).
  • I checked comments rendering with task godocs.
  • I ensured that the title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Assignee, Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@vercel
Copy link

vercel bot commented Dec 14, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ferret-db ✅ Ready (Inspect) Visit Preview Dec 20, 2022 at 2:32PM (UTC)

@vercel vercel bot temporarily deployed to Preview December 14, 2022 03:59 Inactive
@codecov
Copy link

codecov bot commented Dec 14, 2022

Codecov Report

Merging #1647 (bd4fe77) into main (d8af79b) will increase coverage by 17.83%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #1647       +/-   ##
===========================================
+ Coverage   51.11%   68.94%   +17.83%     
===========================================
  Files         289      289               
  Lines       14119    14119               
===========================================
+ Hits         7217     9735     +2518     
+ Misses       6102     3437     -2665     
- Partials      800      947      +147     
Impacted Files Coverage Δ
internal/handlers/tigris/tigrisdb/errors.go 32.14% <0.00%> (-10.72%) ⬇️
internal/handlers/tigris/msg_create.go 67.60% <0.00%> (-7.05%) ⬇️
internal/handlers/tigris/tigrisdb/collections.go 61.90% <0.00%> (-4.77%) ⬇️
internal/util/version/version.go 70.58% <0.00%> (-4.42%) ⬇️
integration/helpers.go 85.50% <0.00%> (+0.96%) ⬆️
internal/handlers/pg/pjson/pjson.go 81.66% <0.00%> (+1.66%) ⬆️
internal/clientconn/listener.go 76.47% <0.00%> (+1.76%) ⬆️
internal/types/document_validation.go 100.00% <0.00%> (+2.53%) ⬆️
internal/handlers/pg/pgdb/tables.go 64.70% <0.00%> (+2.94%) ⬆️
internal/handlers/pg/pgdb/query_iterator.go 76.47% <0.00%> (+2.94%) ⬆️
... and 58 more
Flag Coverage Δ
integration 64.81% <ø> (+24.42%) ⬆️
mongodb 14.35% <ø> (-0.01%) ⬇️
pg 54.02% <ø> (?)
tigris 37.91% <ø> (-0.10%) ⬇️
unit 28.10% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@Fashander Fashander changed the title Add section for supported operators Add section for comparison query operators Dec 15, 2022
@Fashander Fashander self-assigned this Dec 15, 2022
@Fashander Fashander added the documentation Something user-visible is badly or not documented label Dec 15, 2022
@vercel vercel bot temporarily deployed to Preview December 15, 2022 02:32 Inactive
@Fashander Fashander added this to the v0.7.1 milestone Dec 15, 2022
@Fashander Fashander requested review from a team, w84thesun, rumyantseva, chilagrow and noisersup and removed request for a team December 15, 2022 02:33
@Fashander Fashander marked this pull request as ready for review December 15, 2022 02:41
@Fashander Fashander requested review from a team and AlekSi December 15, 2022 02:41
@vercel vercel bot temporarily deployed to Preview December 15, 2022 02:42 Inactive
@Fashander Fashander enabled auto-merge (squash) December 15, 2022 02:53
Copy link
Contributor

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this 💪 some early comments.

website/docs/reference/operators/comparison-operators.md Outdated Show resolved Hide resolved
website/docs/reference/operators/comparison-operators.md Outdated Show resolved Hide resolved
website/docs/reference/operators/comparison-operators.md Outdated Show resolved Hide resolved
website/docs/reference/operators/comparison-operators.md Outdated Show resolved Hide resolved
website/docs/reference/operators/comparison-operators.md Outdated Show resolved Hide resolved
Fashander and others added 3 commits December 15, 2022 09:50
Co-authored-by: chilagrow <chi.fujii@ferretdb.io>
Co-authored-by: chilagrow <chi.fujii@ferretdb.io>
Co-authored-by: chilagrow <chi.fujii@ferretdb.io>
@vercel vercel bot temporarily deployed to Preview December 15, 2022 08:53 Inactive
@vercel vercel bot temporarily deployed to Preview December 15, 2022 11:12 Inactive
@vercel vercel bot temporarily deployed to Preview December 16, 2022 00:07 Inactive
@vercel vercel bot temporarily deployed to Preview December 16, 2022 00:12 Inactive
chilagrow
chilagrow previously approved these changes Dec 16, 2022
Copy link
Contributor

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tiny formatting comment. Looking good!

website/docs/reference/operators/logical-operators.md Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview December 16, 2022 09:11 Inactive
@vercel vercel bot temporarily deployed to Preview December 19, 2022 00:57 Inactive
@AlekSi AlekSi modified the milestones: v0.7.1, v0.8.0 Beta Dec 19, 2022
@vercel vercel bot temporarily deployed to Preview December 19, 2022 12:38 Inactive
@Fashander Fashander changed the title Add section for comparison query operators Add section for comparison and logical query operators Dec 20, 2022
@vercel vercel bot temporarily deployed to Preview December 20, 2022 11:19 Inactive
Copy link
Member

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍 👍

LGTM, one tiny formatting note.

@vercel vercel bot temporarily deployed to Preview December 20, 2022 14:32 Inactive
@Fashander Fashander merged commit 64d8687 into FerretDB:main Dec 21, 2022
@Fashander Fashander deleted the operators branch February 1, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Something user-visible is badly or not documented
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add documentation for supported query operators
6 participants