Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable blog post section #1700

Merged
merged 14 commits into from Dec 30, 2022
Merged

Enable blog post section #1700

merged 14 commits into from Dec 30, 2022

Conversation

Fashander
Copy link
Member

@Fashander Fashander commented Dec 27, 2022 •
edited

Description

Closes #1696.

Readiness checklist

  • I added unit tests for new functionality or bug fixes.
  • I added integration tests for new functionality or bug fixes.
  • I added compatibility tests for new functionality or bug fixes.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I added/updated comments for both exported and unexported top-level declarations (functions, types, etc).
  • I checked comments rendering with task godocs.
  • I ensured that the title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Assignee, Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@Fashander Fashander added the documentation Something user-visible is badly or not documented label Dec 27, 2022
@Fashander Fashander requested a review from a team December 27, 2022 13:50
@Fashander Fashander self-assigned this Dec 27, 2022
@Fashander Fashander requested review from w84thesun, rumyantseva, chilagrow and noisersup and removed request for a team December 27, 2022 13:50
@vercel
Copy link

vercel bot commented Dec 27, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ferret-db ✅ Ready (Inspect) Visit Preview Dec 30, 2022 at 11:20AM (UTC)

@vercel vercel bot temporarily deployed to Preview December 27, 2022 13:51 Inactive
@codecov
Copy link

codecov bot commented Dec 27, 2022 •
edited

Codecov Report

Merging #1700 (c7e9dac) into main (5ec7b54) will decrease coverage by 0.12%.
The diff coverage is n/a.

❗ Current head c7e9dac differs from pull request most recent head 0b2881f. Consider uploading reports for the commit 0b2881f to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1700      +/-   ##
==========================================
- Coverage   69.50%   69.37%   -0.13%     
==========================================
  Files         301      301              
  Lines       14233    14233              
==========================================
- Hits         9892     9874      -18     
- Misses       3411     3422      +11     
- Partials      930      937       +7
Impacted Files Coverage Δ
build/version/version.go 63.01% <0.00%> (-4.11%) ⬇️
internal/clientconn/conn.go 44.02% <0.00%> (-2.63%) ⬇️
internal/clientconn/listener.go 75.42% <0.00%> (-1.72%) ⬇️
internal/handlers/common/filter.go 84.86% <0.00%> (-0.88%) ⬇️
internal/handlers/pg/pgdb/databases.go 72.34% <0.00%> (+6.38%) ⬆️
Flag Coverage Δ
integration 65.15% <ø> (-0.11%) ⬇️
mongodb 14.51% <ø> (ø)
pg 54.15% <ø> (-0.11%) ⬇️
tigris 39.02% <ø> (ø)
unit 29.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@vercel vercel bot temporarily deployed to Preview December 27, 2022 17:23 Inactive
@noisersup
Copy link
Member

Is it ready for review?

@Fashander Swarmia
Copy link
Member Author

@noisersup Not yet

@vercel vercel bot temporarily deployed to Preview December 28, 2022 15:17 Inactive
@Fashander Fashander marked this pull request as ready for review December 28, 2022 15:21
@Fashander Fashander requested review from a team and AlekSi December 28, 2022 15:21
@Fashander Fashander enabled auto-merge (squash) December 28, 2022 15:22
@vercel vercel bot temporarily deployed to Preview December 28, 2022 15:23 Inactive
@AlekSi AlekSi marked this pull request as draft December 28, 2022 16:51
auto-merge was automatically disabled December 28, 2022 16:51

Pull request was converted to draft

@vercel vercel bot temporarily deployed to Preview December 29, 2022 09:12 Inactive
@Fashander Fashander added this to the v0.8.0 Beta milestone Dec 29, 2022
@vercel vercel bot temporarily deployed to Preview December 29, 2022 09:24 Inactive
@Fashander Fashander enabled auto-merge (squash) December 29, 2022 09:27
AlekSi
AlekSi reviewed Dec 29, 2022
View reviewed changes
Copy link
Member

@AlekSi AlekSi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is better to separate PR that enables blog from PR that adds a new blog post, as they should be reviewed differently

website/blog/2022-12-28-database-alternatives-mongodb-2023.md Outdated

<!--truncate-->

![5 alternatives to mongoDB](https://i.imgur.com/ejygHXM.png)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should store images in our repo using Git LFS

@vercel vercel bot temporarily deployed to Preview December 29, 2022 12:23 Inactive
rumyantseva
rumyantseva previously approved these changes Dec 29, 2022
View reviewed changes
Copy link
Member

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall (git lfs comment makes sense to me too, yes).

Looking forward to seeing our new blog platform! 🎉

@vercel vercel bot temporarily deployed to Preview December 29, 2022 13:18 Inactive
@vercel vercel bot temporarily deployed to Preview December 29, 2022 14:35 Inactive
@vercel vercel bot temporarily deployed to Preview December 29, 2022 16:44 Inactive
@vercel vercel bot temporarily deployed to Preview December 29, 2022 17:29 Inactive
AlekSi
AlekSi reviewed Dec 29, 2022
View reviewed changes
Copy link
Member

@AlekSi AlekSi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI fails

@vercel vercel bot temporarily deployed to Preview December 29, 2022 18:54 Inactive
@vercel vercel bot temporarily deployed to Preview December 29, 2022 18:57 Inactive
@vercel vercel bot temporarily deployed to Preview December 30, 2022 11:20 Inactive
@AlekSi AlekSi changed the title Enable Section for Blog Posts Enable blog post section Dec 30, 2022
@AlekSi AlekSi disabled auto-merge December 30, 2022 11:21
@AlekSi AlekSi merged commit 47e2246 into FerretDB:main Dec 30, 2022
@Fashander Fashander deleted the blog-section branch February 1, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlekSi AlekSi AlekSi approved these changes

@w84thesun w84thesun Awaiting requested review from w84thesun w84thesun was automatically assigned from FerretDB/core

@chilagrow chilagrow Awaiting requested review from chilagrow chilagrow was automatically assigned from FerretDB/core

@noisersup noisersup Awaiting requested review from noisersup noisersup was automatically assigned from FerretDB/core

@rumyantseva rumyantseva Awaiting requested review from rumyantseva

Assignees

@Fashander Fashander

Labels
documentation Something user-visible is badly or not documented
Projects
None yet
Milestone
v0.8.0 Beta
Development

Successfully merging this pull request may close these issues.

Enable blog post section
4 participants
@Fashander @noisersup @AlekSi @rumyantseva