Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor refactorings of iterators #1718

Merged
merged 10 commits into from Dec 29, 2022
Merged

Minor refactorings of iterators #1718

merged 10 commits into from Dec 29, 2022

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Dec 29, 2022

Description

Unify how we use iterators.

Readiness checklist

  • I added unit tests for new functionality or bug fixes.
  • I added integration tests for new functionality or bug fixes.
  • I added compatibility tests for new functionality or bug fixes.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I added/updated comments for both exported and unexported top-level declarations (functions, types, etc).
  • I checked comments rendering with task godocs.
  • I ensured that the title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Assignee, Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added the code/chore Code maintenance improvements label Dec 29, 2022
@AlekSi AlekSi self-assigned this Dec 29, 2022
@vercel
Copy link

vercel bot commented Dec 29, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ferret-db ✅ Ready (Inspect) Visit Preview Dec 29, 2022 at 1:20PM (UTC)

@AlekSi AlekSi added this to the v0.8.0 Beta milestone Dec 29, 2022
@vercel vercel bot temporarily deployed to Preview December 29, 2022 11:25 Inactive
@codecov
Copy link

codecov bot commented Dec 29, 2022

Codecov Report

Merging #1718 (1cf1230) into main (af17fa7) will increase coverage by 0.05%.
The diff coverage is 85.55%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1718      +/-   ##
==========================================
+ Coverage   69.34%   69.39%   +0.05%     
==========================================
  Files         300      301       +1     
  Lines       14135    14124      -11     
==========================================
  Hits         9802     9802              
+ Misses       3413     3402      -11     
  Partials      920      920              
Impacted Files Coverage Δ
internal/handlers/tigris/msg_getparameter.go 0.00% <0.00%> (ø)
internal/handlers/tigris/tigrisdb/databases.go 57.50% <0.00%> (ø)
internal/handlers/pg/msg_getparameter.go 82.47% <88.88%> (-0.69%) ⬇️
internal/handlers/pg/pgdb/query_iterator.go 76.47% <92.85%> (ø)
internal/handlers/pg/msg_delete.go 69.18% <100.00%> (-0.50%) ⬇️
internal/handlers/pg/msg_find.go 74.71% <100.00%> (+1.51%) ⬆️
internal/handlers/pg/pgdb/collections.go 64.56% <100.00%> (ø)
internal/handlers/pg/pgdb/query.go 68.68% <100.00%> (ø)
internal/handlers/pg/pgdb/transactions.go 68.51% <100.00%> (+7.15%) ⬆️
internal/types/array.go 75.00% <100.00%> (-1.28%) ⬇️
... and 7 more
Flag Coverage Δ
integration 65.21% <71.11%> (+0.08%) ⬆️
mongodb 14.46% <0.00%> (+0.01%) ⬆️
pg 54.19% <71.11%> (+0.07%) ⬆️
tigris 39.26% <0.00%> (+0.03%) ⬆️
unit 29.12% <56.66%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi changed the title Iterators Minor refactorings of iterators Dec 29, 2022
@AlekSi AlekSi marked this pull request as ready for review December 29, 2022 12:18
@AlekSi AlekSi requested a review from a team as a code owner December 29, 2022 12:19
@AlekSi AlekSi requested review from w84thesun, rumyantseva, chilagrow, a team and noisersup and removed request for a team December 29, 2022 12:19
@AlekSi AlekSi enabled auto-merge (squash) December 29, 2022 12:19
@vercel vercel bot temporarily deployed to Preview December 29, 2022 12:27 Inactive
rumyantseva
rumyantseva previously approved these changes Dec 29, 2022
Copy link
Member

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 :shipit:

@vercel vercel bot temporarily deployed to Preview December 29, 2022 12:57 Inactive
Copy link
Member

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vercel vercel bot temporarily deployed to Preview December 29, 2022 13:20 Inactive
@AlekSi AlekSi disabled auto-merge December 29, 2022 16:41
@AlekSi AlekSi merged commit f06f646 into FerretDB:main Dec 29, 2022
@AlekSi AlekSi deleted the iterators branch December 29, 2022 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants