-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move $mod to compat test #1748
Move $mod to compat test #1748
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1748 +/- ##
==========================================
+ Coverage 68.99% 69.06% +0.06%
==========================================
Files 307 307
Lines 14585 14568 -17
==========================================
- Hits 10063 10061 -2
+ Misses 3559 3548 -11
+ Partials 963 959 -4
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look reasonable to me, added one tiny suggestion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These parts of the code are for sure very mindblowing to read 😆 but I hope I understood it well. Overall LGTM, I didn't find any test case omitted and overall I think I understand the logic. left a couple questions
Description
Closes #1577.
TestCommandsDiagnosticValidate
tests started failing onnrecords
check ontest-integration-mongodb
, I'm not sure what is the cause, for this PR I increased the margin for that.Readiness checklist
task all
, and it passed.task godocs
.@FerretDB/core
), Assignee, Labels, Project and project's Sprint fields.