Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move $mod to compat test #1748

Merged
merged 10 commits into from
Jan 6, 2023
Merged

Conversation

chilagrow
Copy link
Contributor

@chilagrow chilagrow commented Jan 4, 2023

Description

Closes #1577.

  • there are a lot of changes in bitwise tests, they cannot be moved to compat because BitData is not supported. Add support for bitwise operators BinData type #508
  • newly added data to scalars discovered bug on bitwise operation which is fixed in this PR.
  • TestCommandsDiagnosticValidate tests started failing on nrecords check on test-integration-mongodb, I'm not sure what is the cause, for this PR I increased the margin for that.

Readiness checklist

  • I added unit tests for new functionality or bug fixes.
  • I added integration tests for new functionality or bug fixes.
  • I added compatibility tests for new functionality or bug fixes.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I added/updated comments for both exported and unexported top-level declarations (functions, types, etc).
  • I checked comments rendering with task godocs.
  • I ensured that the title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Assignee, Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@chilagrow chilagrow self-assigned this Jan 4, 2023
@vercel
Copy link

vercel bot commented Jan 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ferret-db ✅ Ready (Inspect) Visit Preview Jan 5, 2023 at 3:45PM (UTC)

@vercel vercel bot temporarily deployed to Preview January 4, 2023 08:27 Inactive
@vercel vercel bot temporarily deployed to Preview January 5, 2023 02:21 Inactive
@vercel vercel bot temporarily deployed to Preview January 5, 2023 03:11 Inactive
@vercel vercel bot temporarily deployed to Preview January 5, 2023 05:58 Inactive
@vercel vercel bot temporarily deployed to Preview January 5, 2023 08:27 Inactive
@vercel vercel bot temporarily deployed to Preview January 5, 2023 09:05 Inactive
@vercel vercel bot temporarily deployed to Preview January 5, 2023 09:19 Inactive
@codecov
Copy link

codecov bot commented Jan 5, 2023

Codecov Report

Merging #1748 (de856d2) into main (6990d98) will increase coverage by 0.06%.
The diff coverage is 89.28%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1748      +/-   ##
==========================================
+ Coverage   68.99%   69.06%   +0.06%     
==========================================
  Files         307      307              
  Lines       14585    14568      -17     
==========================================
- Hits        10063    10061       -2     
+ Misses       3559     3548      -11     
+ Partials      963      959       -4     
Impacted Files Coverage Δ
integration/shareddata/scalars.go 100.00% <ø> (ø)
internal/handlers/common/filter.go 85.20% <89.28%> (+0.33%) ⬆️
build/version/version.go 63.01% <0.00%> (-4.11%) ⬇️
internal/clientconn/listener.go 79.54% <0.00%> (+1.70%) ⬆️
internal/clientconn/conn.go 46.95% <0.00%> (+2.60%) ⬆️
Flag Coverage Δ
integration 64.02% <89.28%> (+0.08%) ⬆️
mongodb 5.86% <0.00%> (+<0.01%) ⬆️
pg 52.65% <89.28%> (+0.06%) ⬆️
tigris 41.44% <53.57%> (+0.66%) ⬆️
unit 28.96% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@chilagrow chilagrow marked this pull request as ready for review January 5, 2023 09:32
@chilagrow chilagrow requested a review from a team as a code owner January 5, 2023 09:32
@chilagrow chilagrow requested review from w84thesun, rumyantseva and a team January 5, 2023 09:32
@chilagrow chilagrow requested review from noisersup and removed request for a team January 5, 2023 09:32
@chilagrow chilagrow enabled auto-merge (squash) January 5, 2023 09:32
Copy link
Member

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look reasonable to me, added one tiny suggestion.

integration/query_bitwise_test.go Show resolved Hide resolved
Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These parts of the code are for sure very mindblowing to read 😆 but I hope I understood it well. Overall LGTM, I didn't find any test case omitted and overall I think I understand the logic. left a couple questions

integration/query_evaluation_test.go Show resolved Hide resolved
internal/handlers/common/filter.go Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview January 5, 2023 15:45 Inactive
@chilagrow chilagrow merged commit 0a9f86b into FerretDB:main Jan 6, 2023
@rumyantseva rumyantseva added this to the v0.8.1 milestone Jan 6, 2023
@AlekSi AlekSi added the code/chore Code maintenance improvements label Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add numbers to Scalar datasets for $mod compat test
4 participants