New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support listIndexes
command
#1960
Support listIndexes
command
#1960
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one! Added some comments.
Co-authored-by: Dmitry <dmitry.eremenko@ferretdb.io>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1960 +/- ##
==========================================
+ Coverage 62.00% 70.03% +8.03%
==========================================
Files 317 317
Lines 15654 15702 +48
==========================================
+ Hits 9706 10997 +1291
+ Misses 5121 3737 -1384
- Partials 827 968 +141
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
} | ||
|
||
// TestCommandsAdministrationRunCommandListIndexes tests the behavior when listIndexes is called through RunCommand. | ||
// It's handy to use it to test the correctness of errors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should test through RunCommand
in general: we want compatibility with apps through drivers, not with specs/docs via RunCommand
. There are some exceptions like drop
that hide some errors, but they are exceptions. There is no need to over-test simple commands like listIndexes
Description
Closes #278.
Readiness checklist
task all
, and it passed.@FerretDB/core
), Assignee, Labels, Project and project's Sprint fields.