Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting "package" variable with a testing flag #2357

Merged
merged 4 commits into from Apr 4, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Apr 4, 2023

Description

That's needed for environments like Civo.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Assignee, Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added code/chore Code maintenance improvements do not merge PRs that should not be merged labels Apr 4, 2023
@AlekSi AlekSi added this to the v1.0.0 GA milestone Apr 4, 2023
@AlekSi AlekSi self-assigned this Apr 4, 2023
@AlekSi AlekSi requested a review from a team April 4, 2023 10:54
@AlekSi AlekSi requested a review from a team as a code owner April 4, 2023 10:54
@AlekSi
Copy link
Member Author

AlekSi commented Apr 4, 2023

@rumyantseva Please set FERRETDB_TEST_TELEMETRY_PACKAGE: civo in your PR

@AlekSi AlekSi enabled auto-merge (squash) April 4, 2023 10:56
Copy link
Member

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks helpful!

@codecov
Copy link

codecov bot commented Apr 4, 2023

Codecov Report

Merging #2357 (5bb3057) into main (eafe7f5) will decrease coverage by 36.77%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2357       +/-   ##
===========================================
- Coverage   63.99%   27.22%   -36.77%     
===========================================
  Files         391      391               
  Lines       18993    18987        -6     
===========================================
- Hits        12155     5170     -6985     
- Misses       5931    13262     +7331     
+ Partials      907      555      -352     
Impacted Files Coverage Δ
build/version/version.go 67.64% <100.00%> (+0.07%) ⬆️

... and 125 files with indirect coverage changes

Flag Coverage Δ
integration 4.79% <0.00%> (-52.09%) ⬇️
mongodb 4.79% <0.00%> (+<0.01%) ⬆️
pg ?
unit 25.88% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@w84thesun w84thesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@AlekSi AlekSi removed the do not merge PRs that should not be merged label Apr 4, 2023
@AlekSi AlekSi merged commit 207ba25 into FerretDB:main Apr 4, 2023
17 of 20 checks passed
@AlekSi AlekSi deleted the custom-package branch April 4, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants