Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce integration benchmarks #2381

Merged
merged 46 commits into from Apr 18, 2023
Merged

Introduce integration benchmarks #2381

merged 46 commits into from Apr 18, 2023

Conversation

noisersup
Copy link
Member

@noisersup noisersup commented Apr 6, 2023

Description

Closes #2378.

This PR introduces changes to setup functions and shareddata to make implementation of different benchmark cases easy. It also implements benchmarks for simple filtering.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Assignee, Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@codecov
Copy link

codecov bot commented Apr 6, 2023

Codecov Report

Merging #2381 (5e3e34e) into main (f1b35e1) will increase coverage by 37.60%.
The diff coverage is 40.87%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2381       +/-   ##
===========================================
+ Coverage   26.67%   64.28%   +37.60%     
===========================================
  Files         395      397        +2     
  Lines       19439    19557      +118     
===========================================
+ Hits         5186    12572     +7386     
+ Misses      13697     6070     -7627     
- Partials      556      915      +359     
Impacted Files Coverage Δ
integration/shareddata/shareddata.go 78.70% <0.00%> (-2.67%) ⬇️
integration/shareddata/iterator.go 21.27% <21.27%> (ø)
integration/shareddata/benchmark.go 47.36% <47.36%> (ø)
integration/setup/setup.go 67.21% <56.92%> (-6.51%) ⬇️

... and 125 files with indirect coverage changes

Flag Coverage Δ
integration 57.43% <40.87%> (+52.75%) ⬆️
mongodb 5.04% <40.87%> (+0.35%) ⬆️
pg 57.35% <40.87%> (?)
unit 25.31% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

chilagrow
chilagrow previously approved these changes Apr 18, 2023
Copy link
Contributor

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

w84thesun
w84thesun previously approved these changes Apr 18, 2023
Copy link
Contributor

@w84thesun w84thesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@AlekSi AlekSi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blockchain code looks weird

integration/setup/setup.go Outdated Show resolved Hide resolved
integration/shareddata/iterator.go Outdated Show resolved Hide resolved
integration/shareddata/iterator.go Outdated Show resolved Hide resolved
integration/shareddata/iterator.go Show resolved Hide resolved
integration/shareddata/shareddata.go Outdated Show resolved Hide resolved
integration/shareddata/shareddata.go Outdated Show resolved Hide resolved
integration/shareddata/shareddata.go Outdated Show resolved Hide resolved
integration/shareddata/shareddata.go Show resolved Hide resolved
@noisersup noisersup dismissed stale reviews from chilagrow and w84thesun via b987364 April 18, 2023 17:10
noisersup and others added 2 commits April 18, 2023 17:10
Co-authored-by: Alexey Palazhchenko <alexey.palazhchenko@gmail.com>
Co-authored-by: Alexey Palazhchenko <alexey.palazhchenko@gmail.com>
@noisersup noisersup requested a review from AlekSi April 18, 2023 17:21
@AlekSi AlekSi disabled auto-merge April 18, 2023 19:27
@AlekSi AlekSi merged commit 4404e49 into FerretDB:main Apr 18, 2023
20 of 21 checks passed
@noisersup noisersup deleted the benchmarks branch April 18, 2023 19:48
fenogentov pushed a commit to fenogentov/FerretDB that referenced this pull request Apr 20, 2023
Closes FerretDB#2378.

Co-authored-by: Elena Grahovac <elena.grahovac@ferretdb.io>
Co-authored-by: Alexey Palazhchenko <alexey.palazhchenko@gmail.com>
Co-authored-by: Alexey Palazhchenko <alexey.palazhchenko@ferretdb.io>
fenogentov pushed a commit to fenogentov/FerretDB that referenced this pull request Apr 20, 2023
Closes FerretDB#2378.

Co-authored-by: Elena Grahovac <elena.grahovac@ferretdb.io>
Co-authored-by: Alexey Palazhchenko <alexey.palazhchenko@gmail.com>
Co-authored-by: Alexey Palazhchenko <alexey.palazhchenko@ferretdb.io>
fenogentov pushed a commit to fenogentov/FerretDB that referenced this pull request Apr 20, 2023
Closes FerretDB#2378.

Co-authored-by: Elena Grahovac <elena.grahovac@ferretdb.io>
Co-authored-by: Alexey Palazhchenko <alexey.palazhchenko@gmail.com>
Co-authored-by: Alexey Palazhchenko <alexey.palazhchenko@ferretdb.io>
fenogentov pushed a commit to fenogentov/FerretDB that referenced this pull request Apr 20, 2023
Closes FerretDB#2378.

Co-authored-by: Elena Grahovac <elena.grahovac@ferretdb.io>
Co-authored-by: Alexey Palazhchenko <alexey.palazhchenko@gmail.com>
Co-authored-by: Alexey Palazhchenko <alexey.palazhchenko@ferretdb.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Introduce integration-level benchmarks
5 participants