Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce integration-level benchmarks #2378

Closed
2 tasks done
noisersup opened this issue Apr 5, 2023 · 0 comments · Fixed by #2381 or #2482
Closed
2 tasks done

Introduce integration-level benchmarks #2378

noisersup opened this issue Apr 5, 2023 · 0 comments · Fixed by #2381 or #2482
Assignees
Labels
code/chore Code maintenance improvements
Milestone

Comments

@noisersup
Copy link
Member

noisersup commented Apr 5, 2023

What should be done?

Let's introduce benchmarks for a various queries to check if we don't regress in performance.

Let's create 2 sets of tests

  • We shouldn't use any external data for that.
  • All tests should compare time between 2 databases
  • We should also create subsets that will run tests with and without pushdown
  • We should compare benchmark results with previous one (benchstat)

Where?

  • integration package. (Consider using subpackage)
@noisersup noisersup added the code/chore Code maintenance improvements label Apr 5, 2023
AlekSi added a commit that referenced this issue Apr 18, 2023
Closes #2378.

Co-authored-by: Elena Grahovac <elena.grahovac@ferretdb.io>
Co-authored-by: Alexey Palazhchenko <alexey.palazhchenko@gmail.com>
Co-authored-by: Alexey Palazhchenko <alexey.palazhchenko@ferretdb.io>
@AlekSi AlekSi reopened this Apr 18, 2023
fenogentov pushed a commit to fenogentov/FerretDB that referenced this issue Apr 20, 2023
Closes FerretDB#2378.

Co-authored-by: Elena Grahovac <elena.grahovac@ferretdb.io>
Co-authored-by: Alexey Palazhchenko <alexey.palazhchenko@gmail.com>
Co-authored-by: Alexey Palazhchenko <alexey.palazhchenko@ferretdb.io>
fenogentov pushed a commit to fenogentov/FerretDB that referenced this issue Apr 20, 2023
Closes FerretDB#2378.

Co-authored-by: Elena Grahovac <elena.grahovac@ferretdb.io>
Co-authored-by: Alexey Palazhchenko <alexey.palazhchenko@gmail.com>
Co-authored-by: Alexey Palazhchenko <alexey.palazhchenko@ferretdb.io>
fenogentov pushed a commit to fenogentov/FerretDB that referenced this issue Apr 20, 2023
Closes FerretDB#2378.

Co-authored-by: Elena Grahovac <elena.grahovac@ferretdb.io>
Co-authored-by: Alexey Palazhchenko <alexey.palazhchenko@gmail.com>
Co-authored-by: Alexey Palazhchenko <alexey.palazhchenko@ferretdb.io>
fenogentov pushed a commit to fenogentov/FerretDB that referenced this issue Apr 20, 2023
Closes FerretDB#2378.

Co-authored-by: Elena Grahovac <elena.grahovac@ferretdb.io>
Co-authored-by: Alexey Palazhchenko <alexey.palazhchenko@gmail.com>
Co-authored-by: Alexey Palazhchenko <alexey.palazhchenko@ferretdb.io>
@AlekSi AlekSi added this to the v1.1.0 milestone May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
Archived in project
4 participants