Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add InsertMany benchmark #2518

Merged
merged 7 commits into from Apr 26, 2023
Merged

Add InsertMany benchmark #2518

merged 7 commits into from Apr 26, 2023

Conversation

raeidish
Copy link
Contributor

@raeidish raeidish commented Apr 26, 2023

Description

Closes #2510.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@raeidish raeidish requested a review from a team as a code owner April 26, 2023 11:30
@rumyantseva rumyantseva requested review from a team, w84thesun and noisersup April 26, 2023 11:51
@codecov
Copy link

codecov bot commented Apr 26, 2023

Codecov Report

Merging #2518 (0939a9f) into main (fc0dac8) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2518   +/-   ##
=======================================
  Coverage   27.02%   27.02%           
=======================================
  Files         400      400           
  Lines       19776    19776           
=======================================
  Hits         5345     5345           
  Misses      13865    13865           
  Partials      566      566           
Flag Coverage Δ
integration 5.11% <ø> (ø)
mongodb 5.11% <ø> (ø)
unit 25.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tried few things to make the results more stable (such as doing a sleep after recreating collection etc), although I didn't notice any improvement. I guess that's the topic for the future investigation :)

The benchmark looks good to me, left minor comment for consistency

integration/benchmarks_test.go Outdated Show resolved Hide resolved
integration/benchmarks_test.go Outdated Show resolved Hide resolved
@noisersup noisersup enabled auto-merge (squash) April 26, 2023 12:16
auto-merge was automatically disabled April 26, 2023 12:17

Head branch was pushed to by a user without write access

raeidish and others added 2 commits April 26, 2023 14:17
Co-authored-by: Patryk Kwiatek <patryk@kwiatek.xyz>
Co-authored-by: Patryk Kwiatek <patryk@kwiatek.xyz>
@raeidish raeidish requested a review from noisersup April 26, 2023 12:20
@noisersup noisersup added the code/enhancement Some user-visible feature could work better label Apr 26, 2023
Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@noisersup noisersup enabled auto-merge (squash) April 26, 2023 12:22
Copy link
Contributor

@w84thesun w84thesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

Copy link
Member

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

@noisersup noisersup merged commit a8cd6b8 into FerretDB:main Apr 26, 2023
20 checks passed
@raeidish raeidish deleted the add_insertmany_benchmark branch April 26, 2023 13:34
@rumyantseva rumyantseva changed the title add InsertMany benchmark Add InsertMany benchmark Apr 26, 2023
@rumyantseva rumyantseva added code/chore Code maintenance improvements and removed code/enhancement Some user-visible feature could work better labels Apr 26, 2023
@AlekSi AlekSi added this to the v1.1.0 milestone May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Perform insertMany in a single transaction
5 participants