Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup of blog post linter for slug #2526

Merged
merged 2 commits into from Apr 28, 2023
Merged

Cleanup of blog post linter for slug #2526

merged 2 commits into from Apr 28, 2023

Conversation

chilagrow
Copy link
Contributor

@chilagrow chilagrow commented Apr 28, 2023 •
edited

Description

Closes #2432.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@chilagrow chilagrow self-assigned this Apr 28, 2023
@chilagrow chilagrow added the code/chore Code maintenance improvements label Apr 28, 2023
@codecov
Copy link

codecov bot commented Apr 28, 2023 •
edited

Codecov Report

Merging #2526 (0018368) into main (5e8b75e) will decrease coverage by 37.54%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2526       +/-   ##
===========================================
- Coverage   64.34%   26.80%   -37.54%     
===========================================
  Files         403      403               
  Lines       19956    19956               
===========================================
- Hits        12840     5350     -7490     
- Misses       6187    14041     +7854     
+ Partials      929      565      -364

see 129 files with indirect coverage changes

Flag Coverage Δ
integration 5.07% <ø> (-52.23%) ⬇️
mongodb 5.07% <ø> (ø)
pg ?
unit 25.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@chilagrow chilagrow changed the title Minor cleanup of blog post slug linter Minor cleanup of blog post linter for slug Apr 28, 2023
@chilagrow chilagrow marked this pull request as ready for review April 28, 2023 06:25
@chilagrow chilagrow requested a review from AlekSi as a code owner April 28, 2023 06:25
@chilagrow chilagrow enabled auto-merge (squash) April 28, 2023 06:26
@chilagrow
Copy link
Contributor Author

@raeidish I've added minor updates to your original work 🤗

w84thesun
w84thesun approved these changes Apr 28, 2023
View reviewed changes
Copy link
Contributor

@w84thesun w84thesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

rumyantseva
rumyantseva approved these changes Apr 28, 2023
View reviewed changes
Copy link
Member

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

noisersup
noisersup approved these changes Apr 28, 2023
View reviewed changes
Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chilagrow chilagrow merged commit 203467c into FerretDB:main Apr 28, 2023
23 of 25 checks passed
@AlekSi AlekSi changed the title Minor cleanup of blog post linter for slug Cleanup of blog post linter for slug May 1, 2023
@AlekSi AlekSi added this to the v1.1.0 milestone May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@w84thesun w84thesun w84thesun approved these changes

@rumyantseva rumyantseva rumyantseva approved these changes

@noisersup noisersup noisersup approved these changes

@AlekSi AlekSi Awaiting requested review from AlekSi AlekSi is a code owner

Assignees

@chilagrow chilagrow

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.

Add linter for checking blog posts
5 participants
@chilagrow @w84thesun @rumyantseva @noisersup @AlekSi