Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix $ path errors for sort #2534

Merged
merged 8 commits into from May 3, 2023
Merged

Fix $ path errors for sort #2534

merged 8 commits into from May 3, 2023

Conversation

chilagrow
Copy link
Contributor

@chilagrow chilagrow commented May 1, 2023 •
edited

Description

Closes #2259.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@chilagrow chilagrow added the code/bug Some user-visible feature works incorrectly label May 1, 2023
@chilagrow chilagrow self-assigned this May 1, 2023
@chilagrow chilagrow changed the title Paths with dollar signs Paths with dollar signs in sort returns error May 1, 2023
@codecov
Copy link

codecov bot commented May 1, 2023 •
edited

Codecov Report

Merging #2534 (19b9185) into main (5aca87b) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2534      +/-   ##
==========================================
- Coverage   26.97%   26.95%   -0.02%     
==========================================
  Files         405      405              
  Lines       20110    20119       +9     
==========================================
  Hits         5424     5424              
- Misses      14115    14124       +9     
  Partials      571      571
Impacted Files Coverage Δ
internal/handlers/common/sort.go 6.73% <0.00%> (-0.64%) ⬇️
Flag Coverage Δ
integration 5.02% <0.00%> (-0.01%) ⬇️
mongodb 5.02% <0.00%> (-0.01%) ⬇️
unit 25.58% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@chilagrow chilagrow marked this pull request as ready for review May 1, 2023 06:42
@chilagrow chilagrow requested a review from a team as a code owner May 1, 2023 06:42
@chilagrow chilagrow enabled auto-merge (squash) May 1, 2023 06:43
@chilagrow chilagrow changed the title Paths with dollar signs in sort returns error Fix dollar sign path errors for sort May 2, 2023
@chilagrow chilagrow changed the title Fix dollar sign path errors for sort Fix $ path errors for sort May 2, 2023
rumyantseva
rumyantseva previously approved these changes May 2, 2023
View reviewed changes
internal/handlers/common/sort.go Outdated Show resolved Hide resolved
w84thesun
w84thesun previously approved these changes May 2, 2023
View reviewed changes
Copy link
Contributor

@w84thesun w84thesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

internal/handlers/common/sort.go Outdated Show resolved Hide resolved
@rumyantseva
Update internal/handlers/common/sort.go
0a0f305 
Co-authored-by: Elena Grahovac <elena@grahovac.me>
rumyantseva
rumyantseva previously approved these changes May 3, 2023
View reviewed changes
Copy link
Member

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

w84thesun
w84thesun previously approved these changes May 3, 2023
View reviewed changes
@chilagrow chilagrow merged commit a1aee02 into FerretDB:main May 3, 2023
22 of 23 checks passed
@AlekSi AlekSi added this to the v1.1.0 milestone May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@w84thesun w84thesun w84thesun approved these changes

@rumyantseva rumyantseva rumyantseva approved these changes

@AlekSi AlekSi Awaiting requested review from AlekSi AlekSi is a code owner automatically assigned from FerretDB/leads

@noisersup noisersup Awaiting requested review from noisersup noisersup was automatically assigned from FerretDB/core

Assignees

@chilagrow chilagrow

Labels
code/bug Some user-visible feature works incorrectly
Projects
Current Engineering
Archived in project
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.

Paths with dollar signs are handled incorrectly
4 participants
@chilagrow @w84thesun @rumyantseva @AlekSi