Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax PostgreSQL connection checks #2602

Merged
merged 5 commits into from May 11, 2023
Merged

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented May 10, 2023

Description

Allow more locales, improve error messages and documentation.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added the not ready Issues that are not ready to be worked on; PRs that should skip CI label May 10, 2023
@AlekSi AlekSi added this to the Next milestone May 10, 2023
@AlekSi AlekSi self-assigned this May 10, 2023
@AlekSi AlekSi added code/enhancement Some user-visible feature could work better and removed not ready Issues that are not ready to be worked on; PRs that should skip CI labels May 10, 2023
@AlekSi AlekSi marked this pull request as ready for review May 10, 2023 18:17
@AlekSi AlekSi requested review from ptrfarkas and a team as code owners May 10, 2023 18:17
@AlekSi AlekSi enabled auto-merge (squash) May 10, 2023 18:17
@AlekSi AlekSi requested review from a team, w84thesun, noisersup and Fashander May 10, 2023 18:17
@codecov
Copy link

codecov bot commented May 10, 2023

Codecov Report

Merging #2602 (469de7c) into main (136df12) will increase coverage by 38.53%.
The diff coverage is 78.57%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2602       +/-   ##
===========================================
+ Coverage   27.20%   65.74%   +38.53%     
===========================================
  Files         414      414               
  Lines       20366    20383       +17     
===========================================
+ Hits         5540    13400     +7860     
+ Misses      14248     6032     -8216     
- Partials      578      951      +373     
Impacted Files Coverage Δ
internal/handlers/registry/hana.go 8.33% <0.00%> (-1.67%) ⬇️
internal/handlers/registry/tigris.go 5.00% <0.00%> (-0.56%) ⬇️
internal/handlers/pg/pg.go 79.10% <50.00%> (+58.20%) ⬆️
internal/handlers/pg/pgdb/pool.go 69.46% <88.88%> (+8.44%) ⬆️

... and 135 files with indirect coverage changes

Flag Coverage Δ
integration 58.85% <76.19%> (+53.41%) ⬆️
mongodb 5.44% <0.00%> (-0.01%) ⬇️
pg 58.76% <76.19%> (?)
unit 25.69% <76.19%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one minor question.

website/docs/understanding-ferretdb.md Show resolved Hide resolved
@AlekSi AlekSi added do not merge PRs that should not be merged documentation Something user-visible is badly or not documented trust PRs that can access Actions secrets labels May 11, 2023
@AlekSi
Copy link
Member Author

AlekSi commented May 11, 2023

@Fashander PTAL

@AlekSi AlekSi removed the do not merge PRs that should not be merged label May 11, 2023
@AlekSi AlekSi merged commit 6262587 into FerretDB:main May 11, 2023
45 of 48 checks passed
@AlekSi AlekSi deleted the document-encoding branch May 11, 2023 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/enhancement Some user-visible feature could work better documentation Something user-visible is badly or not documented trust PRs that can access Actions secrets
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants