Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic postcondition checker for errors #2607

Merged
merged 2 commits into from May 11, 2023
Merged

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented May 11, 2023

Description

Closes #1095.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added code/chore Code maintenance improvements not ready Issues that are not ready to be worked on; PRs that should skip CI labels May 11, 2023
@AlekSi AlekSi added this to the Next milestone May 11, 2023
@AlekSi AlekSi self-assigned this May 11, 2023
@AlekSi AlekSi marked this pull request as ready for review May 11, 2023 11:23
@AlekSi AlekSi requested a review from a team as a code owner May 11, 2023 11:23
@AlekSi AlekSi enabled auto-merge (squash) May 11, 2023 11:23
@AlekSi AlekSi requested review from a team, w84thesun and noisersup May 11, 2023 11:23
@AlekSi AlekSi removed the not ready Issues that are not ready to be worked on; PRs that should skip CI label May 11, 2023
@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

Merging #2607 (ffa42e6) into main (0665e99) will decrease coverage by 38.15%.
The diff coverage is 78.57%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2607       +/-   ##
===========================================
- Coverage   65.93%   27.78%   -38.15%     
===========================================
  Files         416      417        +1     
  Lines       20512    20533       +21     
===========================================
- Hits        13524     5705     -7819     
- Misses       6035    14242     +8207     
+ Partials      953      586      -367     
Impacted Files Coverage Δ
internal/handlers/pg/pgdb/databases.go 23.71% <70.00%> (-48.63%) ⬇️
internal/util/contract/contract.go 83.33% <83.33%> (ø)

... and 137 files with indirect coverage changes

Flag Coverage Δ
integration 5.39% <0.00%> (-53.48%) ⬇️
mongodb 5.39% <0.00%> (-0.01%) ⬇️
pg ?
unit 26.21% <78.57%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@w84thesun w84thesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@AlekSi AlekSi merged commit 2271634 into FerretDB:main May 11, 2023
22 of 24 checks passed
@AlekSi AlekSi deleted the contract branch May 11, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Design and prototype common storage interface
3 participants