Separate codebase for aggregation $project and query projection
#2631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chilagrow
changed the title
$project and query projection$project and query projection
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2631 +/- ##
==========================================
- Coverage 28.74% 28.25% -0.50%
==========================================
Files 419 421 +2
Lines 20480 20837 +357
==========================================
Hits 5887 5887
- Misses 13995 14352 +357
Partials 598 598
Flags with carried forward coverage won't be shown. Click here to find out more. |
chilagrow
commented
May 15, 2023
rumyantseva
reviewed
May 15, 2023
rumyantseva
reviewed
May 15, 2023
rumyantseva
reviewed
May 15, 2023
rumyantseva
approved these changes
May 15, 2023
w84thesun
approved these changes
May 15, 2023
AlekSi
reviewed
May 16, 2023
| // - `ErrProjectionExIn` when there is exclusion in inclusion projection; | ||
| // - `ErrProjectionInEx` when there is inclusion in exclusion projection; | ||
| // - `ErrNotImplemented` when there is unimplemented projection operators and expressions; | ||
| // - `errProjectionEmpty` when projection document is empty. |
There was a problem hiding this comment.
CommandError with ErrProjectionExIn code and internal errors like errProjectionEmpty. Not to mention that documentation mixes protocol error codes and Go-level error values.
AlekSi
reviewed
May 16, 2023
| return nil, false, lazyerrors.Error(err) | ||
| } | ||
|
|
||
| if strings.Contains(key, "$") { |
There was a problem hiding this comment.
I think that should be strings.HasPrefix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #2430.
Projection in aggregation and query will diverge. They work differently with operators. In this PR, we create a separate codebase for aggregation.
Readiness checklist
task all, and it passed.@FerretDB/core), Labels, Project and project's Sprint fields.