Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Hana in integration tests #2715

Merged
merged 4 commits into from May 29, 2023
Merged

Conversation

polyal
Copy link
Contributor

@polyal polyal commented May 25, 2023

Description

Closes #{issue_number}.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@polyal polyal requested review from a team and AlekSi as code owners May 25, 2023 21:17
@polyal polyal requested a review from chilagrow May 25, 2023 21:17
@mergify mergify bot assigned polyal May 25, 2023
@polyal
Copy link
Contributor Author

polyal commented May 25, 2023

I used a pr for sql lite that did something similar as a template from last week. I want to be able to run the integration tests locally for future changes before creating a pr.

@codecov
Copy link

codecov bot commented May 25, 2023

Codecov Report

Merging #2715 (4fa1f30) into main (6a63df5) will decrease coverage by 36.82%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2715       +/-   ##
===========================================
- Coverage   63.04%   26.23%   -36.82%     
===========================================
  Files         441      441               
  Lines       22602    22612       +10     
===========================================
- Hits        14250     5932     -8318     
- Misses       7427    16073     +8646     
+ Partials      925      607      -318     
Impacted Files Coverage Δ
integration/setup/listener.go 0.00% <0.00%> (-66.67%) ⬇️
integration/setup/setup.go 62.08% <ø> (-1.10%) ⬇️
integration/shareddata/scalars.go 100.00% <ø> (ø)

... and 143 files with indirect coverage changes

Flag Coverage Δ
integration 4.96% <0.00%> (-51.54%) ⬇️
mongodb 4.96% <0.00%> (-0.01%) ⬇️
pg ?
unit 24.70% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@chilagrow chilagrow added trust PRs that can access Actions secrets not ready Issues that are not ready to be worked on; PRs that should skip CI and removed not ready Issues that are not ready to be worked on; PRs that should skip CI labels May 26, 2023
Copy link
Contributor

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! I have a few comments let me know what you think 🤗

.github/workflows/integration.yml Outdated Show resolved Hide resolved
integration/setup/setup.go Outdated Show resolved Hide resolved
@polyal polyal requested a review from chilagrow May 26, 2023 18:37
@chilagrow chilagrow removed the trust PRs that can access Actions secrets label May 29, 2023
Copy link
Contributor

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@AlekSi AlekSi enabled auto-merge (squash) May 29, 2023 08:55
@AlekSi AlekSi added the code/chore Code maintenance improvements label May 29, 2023
@AlekSi AlekSi added this to the Next milestone May 29, 2023
@AlekSi AlekSi merged commit 631580d into FerretDB:main May 29, 2023
22 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants